Re: [PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-13 Thread Karol Herbst
On Mon, Jul 10, 2023 at 9:23 AM wrote: > > Assignments in if condition are less readable and error-prone. Fixes > also checkpatch warning: > > ERROR: do not use assignment in if condition > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c | 3 ++- > 1 file change

Re: [PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-13 Thread Karol Herbst
Reviewed-by: Karol Herbst On Mon, Jul 10, 2023 at 9:23 AM wrote: > > Assignments in if condition are less readable and error-prone. Fixes > also checkpatch warning: > > ERROR: do not use assignment in if condition > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/nouveau/nvkm/subdev/i2c/bus

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/pad.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 10064

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busgf119.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busnv04.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 1

[PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busnv04.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 =>

Fwd: [PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-10 Thread sunran001
Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/i2c/busnv04.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 =>