Re: [PATCH] drm/nouveau/gr/gf100-: change gf108_gr_fwif from global to static

2022-04-18 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push to the appropriate branch in a moment On Mon, 2022-04-18 at 11:28 -0400, Tom Rix wrote: > Smatch reports this issue > gf108.c:147:1: warning: symbol 'gf108_gr_fwif' >   was not declared. Should it be static? > > gf108_gr_fwif is only used in gf108.c.  Single >

[PATCH] drm/nouveau/gr/gf100-: change gf108_gr_fwif from global to static

2022-04-18 Thread Tom Rix
Smatch reports this issue gf108.c:147:1: warning: symbol 'gf108_gr_fwif' was not declared. Should it be static? gf108_gr_fwif is only used in gf108.c. Single file variables should not be global so change gf108_gr_fwif's storage-class specifier to static. Signed-off-by: Tom Rix --- drivers/gp