Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-18 Thread Ben Skeggs
On Sat, 19 Mar 2022 at 04:11, Lyude Paul wrote: > > Whoops, sorry! I was unsure of the preference in name we should go with so I > poked Ben on the side to ask them, but I can see they haven't yet responded. > I'll poke thme again and see if I can get a response. Yeah, please keep _prom as opposed

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-18 Thread Lyude Paul
Whoops, sorry! I was unsure of the preference in name we should go with so I poked Ben on the side to ask them, but I can see they haven't yet responded. I'll poke thme again and see if I can get a response. On Fri, 2022-03-18 at 10:55 +0100, Christophe Leroy wrote: > Hi Paul, > > Le 05/03/2022 à

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-18 Thread Christophe Leroy
Hi Paul, Le 05/03/2022 à 10:51, Christophe Leroy a écrit : Le 05/03/2022 à 08:38, Christophe Leroy a écrit : Le 04/03/2022 à 21:24, Lyude Paul a écrit : This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because pp

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-05 Thread Christophe Leroy
Le 05/03/2022 à 08:38, Christophe Leroy a écrit : Le 04/03/2022 à 21:24, Lyude Paul a écrit : This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't seem to hit this compilation error). That'

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
Le 04/03/2022 à 21:24, Lyude Paul a écrit : > This mostly looks good to me. Just one question (and one comment down below > that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't > seem to hit this compilation error). That's with PPC64, see http://kisskb.ellerman.id.au/kissk

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Lyude Paul
This mostly looks good to me. Just one question (and one comment down below that needs addressing). Is this with ppc32? (I ask because ppc64le doesn't seem to hit this compilation error). On Fri, 2022-03-04 at 18:20 +0100, Christophe Leroy wrote: > While working on powerpc headers, I ended up with

[PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-04 Thread Christophe Leroy
While working on powerpc headers, I ended up with the following error. drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowrom.c:48:1: error: conflicting types for 'prom_init'; have 'void *(struct nvkm_bios *, const char *)' make[5]: *** [scripts/Makefile.build:288: drivers/gpu/drm/n