Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-29 Thread Greg KH
On Sat, Jan 29, 2022 at 09:19:18AM -0600, Kangjie Lu wrote: > > So to be explicit, so you do not misunderstand me somehow: > > > > No more patches from umn.edu should be accepted into the Linux > > kernel until further public notice. > > This is clear to me. > > > They should be c

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-29 Thread Greg KH
On Sat, Jan 29, 2022 at 08:18:55AM -0600, Kangjie Lu wrote: > On Fri, Jan 28, 2022 at 1:58 PM Karol Herbst wrote: > > > > On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > > > > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > > > Sigh-thank you for catching this - I had tot

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-29 Thread Greg KH
On Fri, Jan 28, 2022 at 02:57:36PM -0500, Lyude Paul wrote: > On Fri, 2022-01-28 at 14:53 -0500, Alex Deucher wrote: > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > > ban. > > > I pushed this already b

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-29 Thread Greg KH
On Fri, Jan 28, 2022 at 02:20:24PM -0500, Lyude Paul wrote: > Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. > I pushed this already but I will go ahead and send a revert for this patch. No worries, thanks for doing this. greg k-h

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-29 Thread Greg KH
On Fri, Jan 28, 2022 at 08:57:56PM +0100, Karol Herbst wrote: > On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > > ban. > > > I pushed this alrea

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:58 PM Karol Herbst wrote: > > On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > > ban. > > > I pushed this already but

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Karol Herbst
On Fri, Jan 28, 2022 at 8:54 PM Alex Deucher wrote: > > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > ban. > > I pushed this already but I will go ahead and send a revert for this patch. > > Will cc you on

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Lyude Paul
On Fri, 2022-01-28 at 14:53 -0500, Alex Deucher wrote: > On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > > > Sigh-thank you for catching this - I had totally forgot about the umn.edu > > ban. > > I pushed this already but I will go ahead and send a revert for this > > patch. > > Will cc you

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Alex Deucher
On Fri, Jan 28, 2022 at 2:20 PM Lyude Paul wrote: > > Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. > I pushed this already but I will go ahead and send a revert for this patch. > Will cc you on it as well. This seems short-sighted. If the patch is valid I see no

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Lyude Paul
Sigh-thank you for catching this - I had totally forgot about the umn.edu ban. I pushed this already but I will go ahead and send a revert for this patch. Will cc you on it as well. On Fri, 2022-01-28 at 11:18 +0100, Greg KH wrote: > On Tue, Jan 25, 2022 at 12:58:55AM +0800, Zhou Qingyang wrote: >

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-28 Thread Greg KH
On Tue, Jan 25, 2022 at 12:58:55AM +0800, Zhou Qingyang wrote: > In nvkm_acr_hsfw_load_bl(), the return value of kmalloc() is directly > passed to memcpy(), which could lead to undefined behavior on failure > of kmalloc(). > > Fix this bug by using kmemdup() instead of kmalloc()+memcpy(). > > Thi

Re: [PATCH] drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

2022-01-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Tue, 2022-01-25 at 00:58 +0800, Zhou Qingyang wrote: > In nvkm_acr_hsfw_load_bl(), the return value of kmalloc() is directly > passed to memcpy(), which could lead to undefined behavior on failure > of kmalloc(). > > Fix this bug by using kmemdup() instead of kmalloc()