Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-15 Thread Dario Binacchi
Hi All, On Thu, Mar 13, 2025 at 3:40 PM Thomas Zimmermann wrote: > > Hi > > Am 13.03.25 um 15:25 schrieb Luca Ceresoli: > > When aperture_remove_all_conflicting_devices() fails, the current code > > returns without going through the rollback actions at the end of the > > function, thus the action

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-14 Thread Thomas Zimmermann
Hi Am 13.03.25 um 21:43 schrieb Dario Binacchi: Hi All, On Thu, Mar 13, 2025 at 3:40 PM Thomas Zimmermann wrote: Hi Am 13.03.25 um 15:25 schrieb Luca Ceresoli: When aperture_remove_all_conflicting_devices() fails, the current code returns without going through the rollback actions at the en

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
Hello Thomas, On Thu, 13 Mar 2025 15:40:43 +0100 Thomas Zimmermann wrote: > > @@ -365,9 +365,10 @@ static int mxsfb_probe(struct platform_device *pdev) > > * located anywhere in RAM > > */ > > ret = aperture_remove_all_conflicting_devices(mxsfb_driver.name); > > - if (ret) > > -

Re: [PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Thomas Zimmermann
Hi Am 13.03.25 um 15:25 schrieb Luca Ceresoli: When aperture_remove_all_conflicting_devices() fails, the current code returns without going through the rollback actions at the end of the function, thus the actions done by drm_dev_alloc() and mxsfb_load() are not undone. Fix by using a goto stat

[PATCH] drm/mxsfb: fix missing rollback on failure in mxsfb_probe()

2025-03-13 Thread Luca Ceresoli
When aperture_remove_all_conflicting_devices() fails, the current code returns without going through the rollback actions at the end of the function, thus the actions done by drm_dev_alloc() and mxsfb_load() are not undone. Fix by using a goto statament, as done for the previous and following erro