Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-28 Thread Dmitry Baryshkov
On Mon, Aug 12, 2024 at 12:41:40PM GMT, Abhinav Kumar wrote: > > > On 8/12/2024 11:40 AM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-08-08 16:52:27) > > > sc7180 programs the ubwc settings as 0x1e as that would mean a > > > highest bank bit of 14 which matches what the GPU sets as well.

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-08-12 12:41:40) > > I just retained the same convention that was used earlier. It seems like > a mix and match right now. sc7180, sm6115 and qcm2290 were using 0x. > > I can post a separate change to change all of them. Sounds good.

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Abhinav Kumar
On 8/12/2024 11:40 AM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-08-08 16:52:27) sc7180 programs the ubwc settings as 0x1e as that would mean a highest bank bit of 14 which matches what the GPU sets as well. However, the highest_bank_bit field of the msm_mdss_data which is being used t

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-08-08 16:52:27) > sc7180 programs the ubwc settings as 0x1e as that would mean a > highest bank bit of 14 which matches what the GPU sets as well. > > However, the highest_bank_bit field of the msm_mdss_data which is > being used to program the SSPP's fetch configuration

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-08-08 16:52:27) > sc7180 programs the ubwc settings as 0x1e as that would mean a > highest bank bit of 14 which matches what the GPU sets as well. > > However, the highest_bank_bit field of the msm_mdss_data which is > being used to program the SSPP's fetch configuration

Re: [PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-12 Thread Rob Clark
On Thu, Aug 8, 2024 at 4:52 PM Abhinav Kumar wrote: > > sc7180 programs the ubwc settings as 0x1e as that would mean a > highest bank bit of 14 which matches what the GPU sets as well. > > However, the highest_bank_bit field of the msm_mdss_data which is > being used to program the SSPP's fetch co

[PATCH] drm/msm: fix the highest_bank_bit for sc7180

2024-08-08 Thread Abhinav Kumar
sc7180 programs the ubwc settings as 0x1e as that would mean a highest bank bit of 14 which matches what the GPU sets as well. However, the highest_bank_bit field of the msm_mdss_data which is being used to program the SSPP's fetch configuration is programmed to a highest bank bit of 16 as 0x3 tra