Re: [PATCH] drm/msm: fix splat when userspace is killed with pending atomic update

2017-05-03 Thread Rob Clark
On Tue, May 2, 2017 at 5:01 AM, Daniel Vetter wrote: > On Fri, Apr 28, 2017 at 8:05 PM, Rob Clark wrote: >> The ->preclose() hook is a good place to block for pending atomic >> updates. We can't do this in ->postclose(), as it needs to happen >> before drm_fb_release(). Otherwise, since we have

Re: [PATCH] drm/msm: fix splat when userspace is killed with pending atomic update

2017-05-02 Thread Daniel Vetter
On Fri, Apr 28, 2017 at 8:05 PM, Rob Clark wrote: > The ->preclose() hook is a good place to block for pending atomic > updates. We can't do this in ->postclose(), as it needs to happen > before drm_fb_release(). Otherwise, since we have already swapped > state (in the case of a non-blocking ato

[PATCH] drm/msm: fix splat when userspace is killed with pending atomic update

2017-04-28 Thread Rob Clark
The ->preclose() hook is a good place to block for pending atomic updates. We can't do this in ->postclose(), as it needs to happen before drm_fb_release(). Otherwise, since we have already swapped state (in the case of a non-blocking atomic update), this means that the plane_state->fb will be re