Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-11 Thread Sai Prakash Ranjan
Hi Jordan, On 2021-01-11 21:41, Jordan Crouse wrote: On Mon, Jan 11, 2021 at 09:54:12AM +0530, Sai Prakash Ranjan wrote: Hi Rob, On 2021-01-08 22:16, Rob Clark wrote: >On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan > wrote: >> >>On 2021-01-08 19:09, Konrad Dybcio wrote: Konrad, can you

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-11 Thread Jordan Crouse
On Mon, Jan 11, 2021 at 09:54:12AM +0530, Sai Prakash Ranjan wrote: > Hi Rob, > > On 2021-01-08 22:16, Rob Clark wrote: > >On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan > > wrote: > >> > >>On 2021-01-08 19:09, Konrad Dybcio wrote: > Konrad, can you please test this below change without yo

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-11 Thread Sai Prakash Ranjan
Hi Rob, On 2021-01-08 22:16, Rob Clark wrote: On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan wrote: On 2021-01-08 19:09, Konrad Dybcio wrote: >> Konrad, can you please test this below change without your change? > > This brings no difference, a BUG still happens. We're still calling > to_a

Re: [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-09 Thread Sai Prakash Ranjan
Hi Rob, Konrad, On 2021-01-07 22:56, Rob Clark wrote: > On Wed, Jan 6, 2021 at 8:50 PM Sai Prakash Ranjan > wrote: >> >> On 2021-01-05 01:00, Konrad Dybcio wrote: >> > Using this code on A5xx (and probably older too) causes a >> > smmu bug. >> > >> > Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add suppor

Re: [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-09 Thread Sai Prakash Ranjan
On 2021-01-08 19:09, Konrad Dybcio wrote: Konrad, can you please test this below change without your change? This brings no difference, a BUG still happens. We're still calling to_a6xx_gpu on ANY device that's probed! Too bad it won't turn my A330 into an A640.. Also, relying on disabling LLCC

Re: [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-09 Thread Konrad Dybcio
> Konrad, can you please test this below change without your change? This brings no difference, a BUG still happens. We're still calling to_a6xx_gpu on ANY device that's probed! Too bad it won't turn my A330 into an A640.. Also, relying on disabling LLCC in the config is out of question as it ma

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-08 Thread Rob Clark
On Fri, Jan 8, 2021 at 6:05 AM Sai Prakash Ranjan wrote: > > On 2021-01-08 19:09, Konrad Dybcio wrote: > >> Konrad, can you please test this below change without your change? > > > > This brings no difference, a BUG still happens. We're still calling > > to_a6xx_gpu on ANY device that's probed! To

Re: [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-07 Thread Rob Clark
On Wed, Jan 6, 2021 at 8:50 PM Sai Prakash Ranjan wrote: > > On 2021-01-05 01:00, Konrad Dybcio wrote: > > Using this code on A5xx (and probably older too) causes a > > smmu bug. > > > > Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system > > cache(LLC)") > > Signed-off-by: Konrad Dyb

Re: [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-07 Thread Sai Prakash Ranjan
On 2021-01-05 01:00, Konrad Dybcio wrote: Using this code on A5xx (and probably older too) causes a smmu bug. Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system cache(LLC)") Signed-off-by: Konrad Dybcio Tested-by: AngeloGioacchino Del Regno --- Reviewed-by: Sai Prakash Ranj

[PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-05 Thread Konrad Dybcio
Using this code on A5xx (and probably older too) causes a smmu bug. Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system cache(LLC)") Signed-off-by: Konrad Dybcio Tested-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 21 - drivers/gp

Re: [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-04 Thread Jordan Crouse
On Mon, Jan 04, 2021 at 08:30:41PM +0100, Konrad Dybcio wrote: > Using this code on A5xx (and probably older too) causes a > smmu bug. > > Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system cache(LLC)") > Signed-off-by: Konrad Dybcio > Tested-by: AngeloGioacchino Del Regno > Yep,