Re: [PATCH] drm/msm: Odd PTR_ERR usage

2013-09-17 Thread Rob Clark
On Mon, Sep 16, 2013 at 5:19 PM, Thomas Meyer wrote: > The variable priv->kms is not initialized yet. > > Found by "scripts/coccinelle/tests/odd_ptr_err.cocci". > PTR_ERR should access the value just tested by IS_ERR. > > Signed-off-by: Thomas Meyer thanks, I've got it queued up BR, -R > --- >

[PATCH] drm/msm: Odd PTR_ERR usage

2013-09-17 Thread Thomas Meyer
The variable priv->kms is not initialized yet. Found by "scripts/coccinelle/tests/odd_ptr_err.cocci". PTR_ERR should access the value just tested by IS_ERR. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c --- a/drivers/gpu/drm/msm/msm_d