Re: [PATCH] drm/msm: Fix potential NULL dereference in DPU

2021-11-25 Thread Dmitry Baryshkov
On 20/10/2021 21:38, Jessica Zhang wrote: Add NULL checks in KMS CRTC funcs to avoid potential NULL dereference. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") I believe that single Fixes is incorrect here. For example snapshot support was added later. I'd suggest to split the patch

[PATCH] drm/msm: Fix potential NULL dereference in DPU

2021-10-20 Thread Jessica Zhang
Add NULL checks in KMS CRTC funcs to avoid potential NULL dereference. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Dan Carpenter Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 8 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

[PATCH] drm/msm: Fix potential NULL dereference in DPU SSPP

2021-10-20 Thread Jessica Zhang
Move initialization of sblk in _sspp_subblk_offset() after NULL check to avoid potential NULL pointer dereference. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reported-by: Dan Carpenter Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 8 +--- 1 file