Re: [PATCH] drm/msm: Fix hw_fence error path cleanup

2023-07-13 Thread Rob Clark
On Thu, Jul 13, 2023 at 1:03 PM Dmitry Baryshkov wrote: > > On 13/07/2023 01:25, Rob Clark wrote: > > From: Rob Clark > > > > In an error path where the submit is free'd without the job being run, > > the hw_fence pointer is simply a kzalloc'd block of memory. In this > > case we should just kfr

Re: [PATCH] drm/msm: Fix hw_fence error path cleanup

2023-07-13 Thread Dmitry Baryshkov
On 13/07/2023 01:25, Rob Clark wrote: From: Rob Clark In an error path where the submit is free'd without the job being run, the hw_fence pointer is simply a kzalloc'd block of memory. In this case we should just kfree() it, rather than trying to decrement it's reference count. Fortunately we

[PATCH] drm/msm: Fix hw_fence error path cleanup

2023-07-12 Thread Rob Clark
From: Rob Clark In an error path where the submit is free'd without the job being run, the hw_fence pointer is simply a kzalloc'd block of memory. In this case we should just kfree() it, rather than trying to decrement it's reference count. Fortunately we can tell that this is the case by check