Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-12 Thread Akhil P Oommen
On 9/10/2021 11:04 PM, Caleb Connolly wrote: On 10/09/2021 18:18, Rob Clark wrote: On Tue, Sep 7, 2021 at 7:20 PM Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9,

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-10 Thread Caleb Connolly
On 10/09/2021 18:18, Rob Clark wrote: On Tue, Sep 7, 2021 at 7:20 PM Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: [..]

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-10 Thread Rob Clark
On Thu, Sep 9, 2021 at 1:54 PM Rob Clark wrote: > > On Thu, Sep 9, 2021 at 12:50 PM Akhil P Oommen wrote: > > > > On 9/9/2021 9:42 PM, Amit Pundir wrote: > > > On Thu, 9 Sept 2021 at 17:47, Amit Pundir wrote: > > >> > > >> On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson > > >> wrote: > > >>> > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-10 Thread Rob Clark
On Tue, Sep 7, 2021 at 7:20 PM Bjorn Andersson wrote: > > On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > > > On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > > > > > > > > On 09/08/2021 17:12, Rob Clark wrote: > > > > On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > > > > wrote: > [..] > > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-09 Thread Rob Clark
On Thu, Sep 9, 2021 at 12:50 PM Akhil P Oommen wrote: > > On 9/9/2021 9:42 PM, Amit Pundir wrote: > > On Thu, 9 Sept 2021 at 17:47, Amit Pundir wrote: > >> > >> On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson > >> wrote: > >>> > >>> On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > >>> >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-09 Thread Akhil P Oommen
On 9/9/2021 9:42 PM, Amit Pundir wrote: On Thu, 9 Sept 2021 at 17:47, Amit Pundir wrote: On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Au

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-09 Thread Amit Pundir
On Thu, 9 Sept 2021 at 17:47, Amit Pundir wrote: > > On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson > wrote: > > > > On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > > > > > On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > > > > > > > > > > > On 09/08/2021 17:12, Rob Clark wrote: > > > > > On M

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-09 Thread Amit Pundir
On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson wrote: > > On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > > > On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > > > > > > > > On 09/08/2021 17:12, Rob Clark wrote: > > > > On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > > > > wrote: > [..] > > > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-08 Thread Caleb Connolly
On 08/09/2021 03:21, Bjorn Andersson wrote: On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: [..] I am a bit confused. We don't define a power domai

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Bjorn Andersson
On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > > > > > On 09/08/2021 17:12, Rob Clark wrote: > > > On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > > > wrote: [..] > > > > I am a bit confused. We don't define a power domain for gpu in dt, > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Bjorn Andersson
On Mon 09 Aug 14:08 PDT 2021, Rob Clark wrote: > On Mon, Aug 9, 2021 at 1:35 PM Caleb Connolly > wrote: > > > > > > > > On 09/08/2021 18:58, Rob Clark wrote: > > > On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen > > > wrote: > > >> > > >> On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > >>> > > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Rob Clark
On Tue, Sep 7, 2021 at 1:25 AM Amit Pundir wrote: > > On Tue, 7 Sept 2021 at 07:11, Rob Clark wrote: > > > > One thing I thought of, which would be worth ruling out, is whether > > this issue only occurs with freq changes immediately after resuming > > the GPU, vs freq changes in general. Could

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Amit Pundir
On Tue, 7 Sept 2021 at 07:11, Rob Clark wrote: > > One thing I thought of, which would be worth ruling out, is whether > this issue only occurs with freq changes immediately after resuming > the GPU, vs freq changes in general. Could you try the below patch. > And if it "fixes" the issue, then tr

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-07 Thread Amit Pundir
On Tue, 7 Sept 2021 at 02:53, Rob Clark wrote: > > On Mon, Sep 6, 2021 at 1:50 PM Rob Clark wrote: > > > > > > ok, I guess it is at least not a board specific thing (ie. won't need > > to introduce some dt binding).. > > > > It would be nice to know what the maximum we can safely increase freq >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-06 Thread Rob Clark
On Mon, Sep 6, 2021 at 12:58 PM Amit Pundir wrote: > > On Mon, 6 Sept 2021 at 21:54, Rob Clark wrote: > > > > On Mon, Sep 6, 2021 at 1:02 AM Amit Pundir wrote: > > > > > > On Sat, 4 Sept 2021 at 01:55, Rob Clark wrote: > > > > > > > > On Fri, Sep 3, 2021 at 12:39 PM John Stultz > > > > wrote:

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-06 Thread Rob Clark
On Mon, Sep 6, 2021 at 1:50 PM Rob Clark wrote: > > On Mon, Sep 6, 2021 at 12:58 PM Amit Pundir wrote: > > > > On Mon, 6 Sept 2021 at 21:54, Rob Clark wrote: > > > > > > On Mon, Sep 6, 2021 at 1:02 AM Amit Pundir wrote: > > > > > > > > On Sat, 4 Sept 2021 at 01:55, Rob Clark wrote: > > > > > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-06 Thread Rob Clark
On Mon, Sep 6, 2021 at 12:58 PM Amit Pundir wrote: > > On Mon, 6 Sept 2021 at 21:54, Rob Clark wrote: > > > > On Mon, Sep 6, 2021 at 1:02 AM Amit Pundir wrote: > > > > > > On Sat, 4 Sept 2021 at 01:55, Rob Clark wrote: > > > > > > > > On Fri, Sep 3, 2021 at 12:39 PM John Stultz > > > > wrote:

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-06 Thread Amit Pundir
On Mon, 6 Sept 2021 at 21:54, Rob Clark wrote: > > On Mon, Sep 6, 2021 at 1:02 AM Amit Pundir wrote: > > > > On Sat, 4 Sept 2021 at 01:55, Rob Clark wrote: > > > > > > On Fri, Sep 3, 2021 at 12:39 PM John Stultz > > > wrote: > > > > > > > > On Thu, Jul 29, 2021 at 1:49 PM Rob Clark wrote: > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-06 Thread Rob Clark
On Mon, Sep 6, 2021 at 1:02 AM Amit Pundir wrote: > > On Sat, 4 Sept 2021 at 01:55, Rob Clark wrote: > > > > On Fri, Sep 3, 2021 at 12:39 PM John Stultz wrote: > > > > > > On Thu, Jul 29, 2021 at 1:49 PM Rob Clark wrote: > > > > On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly > > > > wrote: > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-06 Thread Amit Pundir
On Sat, 4 Sept 2021 at 01:55, Rob Clark wrote: > > On Fri, Sep 3, 2021 at 12:39 PM John Stultz wrote: > > > > On Thu, Jul 29, 2021 at 1:49 PM Rob Clark wrote: > > > On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly > > > wrote: > > > > On 29/07/2021 21:24, Rob Clark wrote: > > > > > On Thu, Jul 29

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-03 Thread Rob Clark
On Fri, Sep 3, 2021 at 12:39 PM John Stultz wrote: > > On Thu, Jul 29, 2021 at 1:49 PM Rob Clark wrote: > > On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly > > wrote: > > > On 29/07/2021 21:24, Rob Clark wrote: > > > > On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly > > > > wrote: > > > >> > > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-03 Thread John Stultz
On Thu, Jul 29, 2021 at 1:49 PM Rob Clark wrote: > On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly > wrote: > > On 29/07/2021 21:24, Rob Clark wrote: > > > On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly > > > wrote: > > >> > > >> Hi Rob, > > >> > > >> I've done some more testing! It looks like be

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 1:35 PM Caleb Connolly wrote: > > > > On 09/08/2021 18:58, Rob Clark wrote: > > On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen > > wrote: > >> > >> On 8/9/2021 9:48 PM, Caleb Connolly wrote: > >>> > >>> > >>> On 09/08/2021 17:12, Rob Clark wrote: > On Mon, Aug 9, 2021

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Caleb Connolly
On 09/08/2021 18:58, Rob Clark wrote: On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen wrote: On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 202

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 10:28 AM Akhil P Oommen wrote: > > On 8/9/2021 9:48 PM, Caleb Connolly wrote: > > > > > > On 09/08/2021 17:12, Rob Clark wrote: > >> On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > >> wrote: > >>> > >>> On 8/8/2021 10:22 PM, Rob Clark wrote: > On Sun, Aug 8, 2021 at 7:

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Akhil P Oommen
On 8/9/2021 9:48 PM, Caleb Connolly wrote: On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Caleb Connolly
On 09/08/2021 17:12, Rob Clark wrote: On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi Rob

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Rob Clark
On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen wrote: > > On 8/8/2021 10:22 PM, Rob Clark wrote: > > On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly > > wrote: > >> > >> > >> > >> On 07/08/2021 21:04, Rob Clark wrote: > >>> On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly > >>> wrote: > >

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-09 Thread Akhil P Oommen
On 8/8/2021 10:22 PM, Rob Clark wrote: On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi Rob, Akhil, On 29/07/2021 21:53, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly w

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-08 Thread Rob Clark
On Sun, Aug 8, 2021 at 7:33 AM Caleb Connolly wrote: > > > > On 07/08/2021 21:04, Rob Clark wrote: > > On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly > > wrote: > >> > >> Hi Rob, Akhil, > >> > >> On 29/07/2021 21:53, Rob Clark wrote: > >>> On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly > >>> wro

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-08 Thread Caleb Connolly
On 07/08/2021 21:04, Rob Clark wrote: On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: Hi Rob, Akhil, On 29/07/2021 21:53, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly wrote: On 29/07/2021 21:24, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-07 Thread Rob Clark
On Sat, Aug 7, 2021 at 12:21 PM Caleb Connolly wrote: > > Hi Rob, Akhil, > > On 29/07/2021 21:53, Rob Clark wrote: > > On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly > > wrote: > >> > >> > >> > >> On 29/07/2021 21:24, Rob Clark wrote: > >>> On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly > >>> wr

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-08-07 Thread Caleb Connolly
Hi Rob, Akhil, On 29/07/2021 21:53, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly wrote: On 29/07/2021 21:24, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly wrote: Hi Rob, I've done some more testing! It looks like before that patch ("drm/msm: Devfreq

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-07-29 Thread Rob Clark
On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly wrote: > > > > On 29/07/2021 21:24, Rob Clark wrote: > > On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly > > wrote: > >> > >> Hi Rob, > >> > >> I've done some more testing! It looks like before that patch ("drm/msm: > >> Devfreq tuning") the GPU woul

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-07-29 Thread Caleb Connolly
On 29/07/2021 21:24, Rob Clark wrote: On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly wrote: Hi Rob, I've done some more testing! It looks like before that patch ("drm/msm: Devfreq tuning") the GPU would never get above the second frequency in the OPP table (342MHz) (at least, not in glxge

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-07-29 Thread Rob Clark
On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly wrote: > > Hi Rob, > > I've done some more testing! It looks like before that patch ("drm/msm: > Devfreq tuning") the GPU would never get above > the second frequency in the OPP table (342MHz) (at least, not in glxgears). > With the patch applied it

Re: [PATCH] drm/msm: Disable frequency clamping on a630

2021-07-29 Thread Caleb Connolly
Hi Rob, I've done some more testing! It looks like before that patch ("drm/msm: Devfreq tuning") the GPU would never get above the second frequency in the OPP table (342MHz) (at least, not in glxgears). With the patch applied it would more aggressively jump up to the max frequency which seems t

[PATCH] drm/msm: Disable frequency clamping on a630

2021-07-29 Thread Rob Clark
From: Rob Clark The more frequent frequency transitions resulting from clamping freq to minimum when the GPU is idle seems to be causing some issue with the bus getting voted off when it should be on. (An enable racing with an async disable?) This might be a problem outside of the GPU, as I can