Re: [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain

2024-12-02 Thread Abhinav Kumar
On 11/11/2024 11:41 PM, Rex Nie wrote: In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL, so the base may be 63, 126, 196, 392. The condition base <= 2046 always true. Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support") Signed-off-by: Rex Nie --- drivers/gp

Re: [PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain

2024-11-14 Thread Dmitry Baryshkov
On Tue, Nov 12, 2024 at 03:41:00PM +0800, Rex Nie wrote: > In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL, > so the base may be 63, 126, 196, 392. The condition base <= 2046 > always true. > > Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support") > Signed-off-by:

[PATCH] drm/msm/hdmi: simplify code in pll_get_integloop_gain

2024-11-12 Thread Rex Nie
In pll_get_integloop_gain(), digclk_divsel=1 or 2, base=63 or 196ULL, so the base may be 63, 126, 196, 392. The condition base <= 2046 always true. Fixes: caedbf17c48d ("drm/msm: add msm8998 hdmi phy/pll support") Signed-off-by: Rex Nie --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +- 1 file