Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-05 Thread Caleb Connolly
On 03/05/2024 22:59, Dmitry Baryshkov wrote: On Fri, May 03, 2024 at 11:18:52AM +0200, Luca Weiss wrote: On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: On Sat, 30 Mar 2024 at 18:49, Marijn Suijten wrote: On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: In case of CMD DSI pane

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-03 Thread Dmitry Baryshkov
On Fri, May 03, 2024 at 11:18:52AM +0200, Luca Weiss wrote: > On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: > > On Sat, 30 Mar 2024 at 18:49, Marijn Suijten > > wrote: > > > > > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > > > In case of CMD DSI panels, the vblank IRQ can be

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-03 Thread Luca Weiss
On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: > On Sat, 30 Mar 2024 at 18:49, Marijn Suijten > wrote: > > > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > > In case of CMD DSI panels, the vblank IRQ can be used outside of > > > irq_enable/irq_disable pair. This results in the

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-04-06 Thread Dmitry Baryshkov
On Sat, 30 Mar 2024 at 18:49, Marijn Suijten wrote: > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > In case of CMD DSI panels, the vblank IRQ can be used outside of > > irq_enable/irq_disable pair. This results in the following kind of > > Can you clarify when exactly that is? Is it via o

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-03-30 Thread Abhinav Kumar
On 3/30/2024 9:49 AM, Marijn Suijten wrote: On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: In case of CMD DSI panels, the vblank IRQ can be used outside of irq_enable/irq_disable pair. This results in the following kind of Can you clarify when exactly that is? Is it via ops.control_vblank

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-03-30 Thread Marijn Suijten
On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > In case of CMD DSI panels, the vblank IRQ can be used outside of > irq_enable/irq_disable pair. This results in the following kind of Can you clarify when exactly that is? Is it via ops.control_vblank_irq in dpu_encoder_toggle_vblank_for_crtc()?

[PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-03-29 Thread Dmitry Baryshkov
In case of CMD DSI panels, the vblank IRQ can be used outside of irq_enable/irq_disable pair. This results in the following kind of messages. Move assignment of IRQ indices to atomic_enable / atomic_disable callbacks. [dpu error]invalid IRQ=[134217727, 31] [drm:dpu_encoder_phys_cmd_control_vblank_