Re: [PATCH] drm/msm/dpu: Don't use devm for component devices

2018-11-02 Thread Jordan Crouse
On Fri, Nov 02, 2018 at 10:57:46AM -0700, Jeykumar Sankaran wrote: > On 2018-11-02 07:30, Jordan Crouse wrote: > >Devices that are bound as components should not use devm since > >device managed memory is not freed when the component is > >unbound. > > > >In particular this is an issue if the compo

Re: [PATCH] drm/msm/dpu: Don't use devm for component devices

2018-11-02 Thread Jeykumar Sankaran
On 2018-11-02 07:30, Jordan Crouse wrote: Devices that are bound as components should not use devm since device managed memory is not freed when the component is unbound. In particular this is an issue if the component bind fails due to an -EPROBE_DEFER. In this case the bind would try again I

Re: [Freedreno] [PATCH] drm/msm/dpu: Don't use devm for component devices

2018-11-02 Thread Sean Paul
On Fri, Nov 02, 2018 at 08:30:08AM -0600, Jordan Crouse wrote: > Devices that are bound as components should not use devm since > device managed memory is not freed when the component is > unbound. > > In particular this is an issue if the component bind fails > due to an -EPROBE_DEFER. In this ca

[PATCH] drm/msm/dpu: Don't use devm for component devices

2018-11-02 Thread Jordan Crouse
Devices that are bound as components should not use devm since device managed memory is not freed when the component is unbound. In particular this is an issue if the component bind fails due to an -EPROBE_DEFER. In this case the bind would try again later and any devm managed memory allocated dur