Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-12 Thread Pavan Kondeti
On Thu, Dec 12, 2024 at 10:40:46AM +, Mark Rutland wrote: > On Thu, Dec 12, 2024 at 08:50:12AM +, Marc Zyngier wrote: > > On Thu, 12 Dec 2024 05:31:00 +, > > Pavan Kondeti wrote: > > > > > > On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > > > > On Wed, 11 Dec 2024 00:3

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-12 Thread Mark Rutland
On Thu, Dec 12, 2024 at 08:50:12AM +, Marc Zyngier wrote: > On Thu, 12 Dec 2024 05:31:00 +, > Pavan Kondeti wrote: > > > > On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > > > On Wed, 11 Dec 2024 00:37:34 +, > > > Pavan Kondeti wrote: > > > > > > > > On Tue, Dec 10, 2

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-12 Thread Marc Zyngier
On Thu, 12 Dec 2024 05:31:00 +, Pavan Kondeti wrote: > > On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > > On Wed, 11 Dec 2024 00:37:34 +, > > Pavan Kondeti wrote: > > > > > > On Tue, Dec 10, 2024 at 09:24:03PM +, Marc Zyngier wrote: > > > > > +static int a6xx_switch

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-11 Thread Pavan Kondeti
On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > On Wed, 11 Dec 2024 00:37:34 +, > Pavan Kondeti wrote: > > > > On Tue, Dec 10, 2024 at 09:24:03PM +, Marc Zyngier wrote: > > > > +static int a6xx_switch_secure_mode(struct msm_gpu *gpu) > > > > +{ > > > > + int ret; > >

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-11 Thread Marc Zyngier
On Wed, 11 Dec 2024 00:37:34 +, Pavan Kondeti wrote: > > On Tue, Dec 10, 2024 at 09:24:03PM +, Marc Zyngier wrote: > > > +static int a6xx_switch_secure_mode(struct msm_gpu *gpu) > > > +{ > > > + int ret; > > > + > > > +#ifdef CONFIG_ARM64 > > > + /* > > > + * We can access SECVID_TRUST_C

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-11 Thread Dmitry Baryshkov
On Wed, Dec 11, 2024 at 01:06:58PM +0530, Pavan Kondeti wrote: > +devicetree > > On Tue, Dec 10, 2024 at 07:43:19PM -0800, Rob Clark wrote: > > On Tue, Dec 10, 2024 at 7:08 PM Akhil P Oommen > > wrote: > > > > > > On 12/11/2024 6:43 AM, Bjorn Andersson wrote: > > > > On Tue, Dec 10, 2024 at 02:2

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-11 Thread Pavan Kondeti
On Wed, Dec 11, 2024 at 10:52:51AM +0200, Dmitry Baryshkov wrote: > On Wed, Dec 11, 2024 at 01:06:58PM +0530, Pavan Kondeti wrote: > > +devicetree > > > > On Tue, Dec 10, 2024 at 07:43:19PM -0800, Rob Clark wrote: > > > On Tue, Dec 10, 2024 at 7:08 PM Akhil P Oommen > > > wrote: > > > > > > > >

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Pavan Kondeti
+devicetree On Tue, Dec 10, 2024 at 07:43:19PM -0800, Rob Clark wrote: > On Tue, Dec 10, 2024 at 7:08 PM Akhil P Oommen > wrote: > > > > On 12/11/2024 6:43 AM, Bjorn Andersson wrote: > > > On Tue, Dec 10, 2024 at 02:22:27AM +0530, Akhil P Oommen wrote: > > >> On 12/10/2024 1:24 AM, Rob Clark wro

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Pavan Kondeti
On Tue, Dec 10, 2024 at 09:24:03PM +, Marc Zyngier wrote: > > +static int a6xx_switch_secure_mode(struct msm_gpu *gpu) > > +{ > > + int ret; > > + > > +#ifdef CONFIG_ARM64 > > + /* > > +* We can access SECVID_TRUST_CNTL register when kernel is booted in > > EL2 mode. So, use it > > +

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Pavan Kondeti
On Tue, Dec 10, 2024 at 05:52:27PM -0500, Connor Abbott wrote: > On Mon, Dec 9, 2024 at 3:20 AM Akhil P Oommen > wrote: > > > > When kernel is booted in EL2, SECVID registers are accessible to the > > KMD. So we can use that to switch GPU's secure mode to avoid dependency > > on Zap firmware. Als

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Rob Clark
On Tue, Dec 10, 2024 at 7:08 PM Akhil P Oommen wrote: > > On 12/11/2024 6:43 AM, Bjorn Andersson wrote: > > On Tue, Dec 10, 2024 at 02:22:27AM +0530, Akhil P Oommen wrote: > >> On 12/10/2024 1:24 AM, Rob Clark wrote: > >>> On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen > >>> wrote: > >

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Akhil P Oommen
On 12/11/2024 2:24 AM, Elliot Berman wrote: > On Mon, Dec 09, 2024 at 01:49:15PM +0530, Akhil P Oommen wrote: >> When kernel is booted in EL2, SECVID registers are accessible to the >> KMD. So we can use that to switch GPU's secure mode to avoid dependency >> on Zap firmware. Also, we can't load a

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Akhil P Oommen
On 12/11/2024 6:43 AM, Bjorn Andersson wrote: > On Tue, Dec 10, 2024 at 02:22:27AM +0530, Akhil P Oommen wrote: >> On 12/10/2024 1:24 AM, Rob Clark wrote: >>> On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen >>> wrote: When kernel is booted in EL2, SECVID registers are accessible to the >

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Bjorn Andersson
On Tue, Dec 10, 2024 at 02:22:27AM +0530, Akhil P Oommen wrote: > On 12/10/2024 1:24 AM, Rob Clark wrote: > > On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen > > wrote: > >> > >> When kernel is booted in EL2, SECVID registers are accessible to the > >> KMD. So we can use that to switch GPU's secur

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Connor Abbott
On Mon, Dec 9, 2024 at 3:20 AM Akhil P Oommen wrote: > > When kernel is booted in EL2, SECVID registers are accessible to the > KMD. So we can use that to switch GPU's secure mode to avoid dependency > on Zap firmware. Also, we can't load a secure firmware without a > hypervisor that supports it.

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Marc Zyngier
On Mon, 09 Dec 2024 08:19:15 +, Akhil P Oommen wrote: > > When kernel is booted in EL2, SECVID registers are accessible to the > KMD. So we can use that to switch GPU's secure mode to avoid dependency > on Zap firmware. Also, we can't load a secure firmware without a > hypervisor that support

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Elliot Berman
On Mon, Dec 09, 2024 at 01:49:15PM +0530, Akhil P Oommen wrote: > When kernel is booted in EL2, SECVID registers are accessible to the > KMD. So we can use that to switch GPU's secure mode to avoid dependency > on Zap firmware. Also, we can't load a secure firmware without a > hypervisor that suppo

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-10 Thread Akhil P Oommen
On 12/10/2024 3:26 AM, Rob Clark wrote: > On Mon, Dec 9, 2024 at 12:52 PM Akhil P Oommen > wrote: >> >> On 12/10/2024 1:24 AM, Rob Clark wrote: >>> On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen >>> wrote: When kernel is booted in EL2, SECVID registers are accessible to the KMD.

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-09 Thread Rob Clark
On Mon, Dec 9, 2024 at 12:52 PM Akhil P Oommen wrote: > > On 12/10/2024 1:24 AM, Rob Clark wrote: > > On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen > > wrote: > >> > >> When kernel is booted in EL2, SECVID registers are accessible to the > >> KMD. So we can use that to switch GPU's secure mode

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-09 Thread Akhil P Oommen
On 12/10/2024 1:24 AM, Rob Clark wrote: > On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen > wrote: >> >> When kernel is booted in EL2, SECVID registers are accessible to the >> KMD. So we can use that to switch GPU's secure mode to avoid dependency >> on Zap firmware. Also, we can't load a secure

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-09 Thread Akhil P Oommen
On 12/9/2024 8:33 PM, Konrad Dybcio wrote: > On 9.12.2024 9:19 AM, Akhil P Oommen wrote: >> When kernel is booted in EL2, SECVID registers are accessible to the >> KMD. So we can use that to switch GPU's secure mode to avoid dependency >> on Zap firmware. Also, we can't load a secure firmware witho

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-09 Thread Rob Clark
On Mon, Dec 9, 2024 at 12:20 AM Akhil P Oommen wrote: > > When kernel is booted in EL2, SECVID registers are accessible to the > KMD. So we can use that to switch GPU's secure mode to avoid dependency > on Zap firmware. Also, we can't load a secure firmware without a > hypervisor that supports it.

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-09 Thread Konrad Dybcio
On 9.12.2024 9:19 AM, Akhil P Oommen wrote: > When kernel is booted in EL2, SECVID registers are accessible to the > KMD. So we can use that to switch GPU's secure mode to avoid dependency > on Zap firmware. Also, we can't load a secure firmware without a > hypervisor that supports it. > > Tested

[PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-09 Thread Akhil P Oommen
When kernel is booted in EL2, SECVID registers are accessible to the KMD. So we can use that to switch GPU's secure mode to avoid dependency on Zap firmware. Also, we can't load a secure firmware without a hypervisor that supports it. Tested following configurations on sa8775p chipset (Adreno 663