Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 12:31:50PM +0100, Konrad Dybcio wrote: > On 28.10.2024 11:52 AM, Dmitry Baryshkov wrote: > > On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: > >> On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > >>> On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen > >>> wrote:

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > Clang-19 and above sometimes end up with multiple copies of the large > a6xx_hfi_msg_bw_table structure on the stack. The problem is that > a6xx_hfi_send_bw_table() calls a number of device specific functions to > fill the structure,

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 11:52 AM, Dmitry Baryshkov wrote: > On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: >> On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: >>> On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen >>> wrote: On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > On Sun, Oc

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: > On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > > On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen > > wrote: > >> > >> On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > >>> On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrot

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 11:39:16AM +0100, Konrad Dybcio wrote: > On 28.10.2024 10:52 AM, Akhil P Oommen wrote: > > On 10/28/2024 12:13 AM, Arnd Bergmann wrote: > >> On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: > >>> Clang-19 and above sometimes end up with multiple copies of the large > >>

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen wrote: > > On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > > On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > >> Clang-19 and above sometimes end up with multiple copies of the large > >> a6xx_hfi_msg_bw_table structure on the stack. T

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 10:52 AM, Akhil P Oommen wrote: > On 10/28/2024 12:13 AM, Arnd Bergmann wrote: >> On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: >>> Clang-19 and above sometimes end up with multiple copies of the large >>> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >>> a

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Konrad Dybcio
On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen wrote: >> >> On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: >>> On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: Clang-19 and above sometimes end up with multiple copies of the large

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Akhil P Oommen
On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: >> Clang-19 and above sometimes end up with multiple copies of the large >> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >> a6xx_hfi_send_bw_table() calls a number o

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Akhil P Oommen
On 10/28/2024 12:13 AM, Arnd Bergmann wrote: > On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: >> Clang-19 and above sometimes end up with multiple copies of the large >> a6xx_hfi_msg_bw_table structure on the stack. The problem is that >> a6xx_hfi_send_bw_table() calls a number of device spe

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > Clang-19 and above sometimes end up with multiple copies of the large > a6xx_hfi_msg_bw_table structure on the stack. The problem is that > a6xx_hfi_send_bw_table() calls a number of device specific functions to > fill the structure,

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-27 Thread Arnd Bergmann
On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: > Clang-19 and above sometimes end up with multiple copies of the large > a6xx_hfi_msg_bw_table structure on the stack. The problem is that > a6xx_hfi_send_bw_table() calls a number of device specific functions to > fill the structure, but these

[PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-27 Thread Akhil P Oommen
Clang-19 and above sometimes end up with multiple copies of the large a6xx_hfi_msg_bw_table structure on the stack. The problem is that a6xx_hfi_send_bw_table() calls a number of device specific functions to fill the structure, but these create another copy of the structure on the stack which gets