Re: [PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

2023-04-27 Thread neil . armstrong
On 23/04/2023 23:36, Martin Blumenstingl wrote: On Sun, Apr 23, 2023 at 4:53 PM Tom Rix wrote: smatch has several simailar warnings to s/simailar/similar/ drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol 'meson_hdmi_enci_mode_480i' was not declared. Should it be static? These

Re: [PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

2023-04-27 Thread Neil Armstrong
Hi, On Sun, 23 Apr 2023 10:53:00 -0400, Tom Rix wrote: > smatch has several simailar warnings to > drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol > 'meson_hdmi_enci_mode_480i' was not declared. Should it be static? > > These variables are only used in their defining file so should b

Re: [PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

2023-04-23 Thread Martin Blumenstingl
On Sun, Apr 23, 2023 at 4:53 PM Tom Rix wrote: > > smatch has several simailar warnings to s/simailar/similar/ > drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol > 'meson_hdmi_enci_mode_480i' was not declared. Should it be static? > > These variables are only used in their defining fi

[PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

2023-04-23 Thread Tom Rix
smatch has several simailar warnings to drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol 'meson_hdmi_enci_mode_480i' was not declared. Should it be static? These variables are only used in their defining file so should be static Signed-off-by: Tom Rix --- drivers/gpu/drm/meson/meson