Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion again

2023-03-15 Thread Neil Armstrong
Hi, On Thu, 09 Mar 2023 16:24:46 +0100, Marek Szyprowski wrote: > devm_regulator_get_enable_optional() returns -ENODEV if requested > optional regulator is not present. Adjust code for that, because in the > 67d0a30128c9 I've incorrectly assumed that it also returns 0 when > regulator is not prese

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion again

2023-03-10 Thread Neil Armstrong
On 09/03/2023 16:24, Marek Szyprowski wrote: devm_regulator_get_enable_optional() returns -ENODEV if requested optional regulator is not present. Adjust code for that, because in the 67d0a30128c9 I've incorrectly assumed that it also returns 0 when regulator is not present. Reported-by: Ricardo

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion again

2023-03-09 Thread Martin Blumenstingl
On Thu, Mar 9, 2023 at 4:24 PM Marek Szyprowski wrote: > > devm_regulator_get_enable_optional() returns -ENODEV if requested > optional regulator is not present. Adjust code for that, because in the > 67d0a30128c9 I've incorrectly assumed that it also returns 0 when > regulator is not present. > >

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion again

2023-03-09 Thread Neil Armstrong
On 09/03/2023 16:24, Marek Szyprowski wrote: devm_regulator_get_enable_optional() returns -ENODEV if requested optional regulator is not present. Adjust code for that, because in the 67d0a30128c9 I've incorrectly assumed that it also returns 0 when regulator is not present. Reported-by: Ricardo

[PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion again

2023-03-09 Thread Marek Szyprowski
devm_regulator_get_enable_optional() returns -ENODEV if requested optional regulator is not present. Adjust code for that, because in the 67d0a30128c9 I've incorrectly assumed that it also returns 0 when regulator is not present. Reported-by: Ricardo Cañuelo Fixes: 67d0a30128c9 ("drm/meson: dw-hd

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-03-09 Thread Marek Szyprowski
Hi Ricardo, On 09.03.2023 09:55, Ricardo Cañuelo wrote: > On lun 09-01-2023 23:00:33, Marek Szyprowski wrote: >> devm_regulator_get_enable_optional() function returns 0 on success, so >> use it for the check if function succeded instead of the -ENODEV value. >> >> Fixes: 429e87063661 ("drm/meson:

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-03-09 Thread Ricardo Cañuelo
Hi Marek, On lun 09-01-2023 23:00:33, Marek Szyprowski wrote: > devm_regulator_get_enable_optional() function returns 0 on success, so > use it for the check if function succeded instead of the -ENODEV value. > > Fixes: 429e87063661 ("drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()") > Sign

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-01-10 Thread Neil Armstrong
Hi, On Mon, 09 Jan 2023 23:00:33 +0100, Marek Szyprowski wrote: > devm_regulator_get_enable_optional() function returns 0 on success, so > use it for the check if function succeded instead of the -ENODEV value. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-mi

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-01-10 Thread Neil Armstrong
On 09/01/2023 23:00, Marek Szyprowski wrote: devm_regulator_get_enable_optional() function returns 0 on success, so use it for the check if function succeded instead of the -ENODEV value. Fixes: 429e87063661 ("drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()") Signed-off-by: Marek Szyprowsk

[PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-01-09 Thread Marek Szyprowski
devm_regulator_get_enable_optional() function returns 0 on success, so use it for the check if function succeded instead of the -ENODEV value. Fixes: 429e87063661 ("drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()") Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/meson/meson_dw_hdmi.c |