Re: [PATCH] drm/meson: Fix OSD1 RGB to YCbCr coefficient

2022-09-09 Thread Neil Armstrong
Hi, On Thu, 8 Sep 2022 16:52:43 +0100, Stuart Menefy wrote: > VPP_WRAP_OSD1_MATRIX_COEF22.Coeff22 is documented as being bits 0-12, > not 16-28. > > Without this the output tends to have a pink hue, changing it results > in better color accuracy. > > The vendor kernel doesn't use this register.

Re: [PATCH] drm/meson: Fix OSD1 RGB to YCbCr coefficient

2022-09-09 Thread Neil Armstrong
Hi ! On 08/09/2022 17:52, Stuart Menefy wrote: VPP_WRAP_OSD1_MATRIX_COEF22.Coeff22 is documented as being bits 0-12, not 16-28. Thanks, Good catch ! Without this the output tends to have a pink hue, changing it results in better color accuracy. Indeed, it was a regular issue reported.

[PATCH] drm/meson: Fix OSD1 RGB to YCbCr coefficient

2022-09-08 Thread Stuart Menefy
VPP_WRAP_OSD1_MATRIX_COEF22.Coeff22 is documented as being bits 0-12, not 16-28. Without this the output tends to have a pink hue, changing it results in better color accuracy. The vendor kernel doesn't use this register. However the code which sets VIU2_OSD1_MATRIX_COEF22 also uses bits 0-12. Th