Re: [PATCH] drm/meson: Correct OSD1 global alpha value

2022-09-09 Thread Neil Armstrong
Hi, On Thu, 8 Sep 2022 16:51:03 +0100, Stuart Menefy wrote: > VIU_OSD1_CTRL_STAT.GLOBAL_ALPHA is a 9 bit field, so the maximum > value is 0x100 not 0xff. > > This matches the vendor kernel. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/1] drm

Re: [PATCH] drm/meson: Correct OSD1 global alpha value

2022-09-09 Thread Neil Armstrong
Hi, Thanks for submitting this patch ! On 08/09/2022 17:51, Stuart Menefy wrote: VIU_OSD1_CTRL_STAT.GLOBAL_ALPHA is a 9 bit field, so the maximum value is 0x100 not 0xff. Indeed it's 9bit, but all bits to 1 would be 0x1ff then, but indeed vendor uses : #define OSD_GLOBAL_ALPHA_DEF 0x100 Th

[PATCH] drm/meson: Correct OSD1 global alpha value

2022-09-08 Thread Stuart Menefy
VIU_OSD1_CTRL_STAT.GLOBAL_ALPHA is a 9 bit field, so the maximum value is 0x100 not 0xff. This matches the vendor kernel. Signed-off-by: Stuart Menefy --- drivers/gpu/drm/meson/meson_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_plane.c