Re: [PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff()

2022-09-21 Thread Allen-KH Cheng
On 9/19/22 21:32, AngeloGioacchino Del Regno wrote: > Il 19/09/22 10:40, Hsin-Yi Wang ha scritto: >> On Mon, Sep 19, 2022 at 4:39 PM Nícolas F. R. A. Prado >> wrote: >>> >>> As the comment right before the mtk_dsi_stop() call advises, >>> mtk_dsi_stop() should only be called after >>> mtk_drm_c

Re: [PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff()

2022-09-19 Thread AngeloGioacchino Del Regno
Il 19/09/22 10:40, Hsin-Yi Wang ha scritto: On Mon, Sep 19, 2022 at 4:39 PM Nícolas F. R. A. Prado wrote: As the comment right before the mtk_dsi_stop() call advises, mtk_dsi_stop() should only be called after mtk_drm_crtc_atomic_disable(). That's because that function calls drm_crtc_wait_one_

Re: [PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff()

2022-09-19 Thread Hsin-Yi Wang
On Mon, Sep 19, 2022 at 4:39 PM Nícolas F. R. A. Prado wrote: > > As the comment right before the mtk_dsi_stop() call advises, > mtk_dsi_stop() should only be called after > mtk_drm_crtc_atomic_disable(). That's because that function calls > drm_crtc_wait_one_vblank(), which requires the vblank ir

[PATCH] drm/mediatek: dsi: Move mtk_dsi_stop() call back to mtk_dsi_poweroff()

2022-08-04 Thread Nícolas F . R . A . Prado
As the comment right before the mtk_dsi_stop() call advises, mtk_dsi_stop() should only be called after mtk_drm_crtc_atomic_disable(). That's because that function calls drm_crtc_wait_one_vblank(), which requires the vblank irq to be enabled. Previously mtk_dsi_stop(), being in mtk_dsi_poweroff()