Re: [PATCH] drm/mediatek: Set Rotation default value to 1.

2021-10-25 Thread Sean Paul
On Mon, Oct 25, 2021 at 09:11:54PM -0400, Sean Paul wrote: > On Fri, Oct 22, 2021 at 12:54:02PM -0400, Mark Yacoub wrote: > > From: Mark Yacoub > > > > [Why] > > The Rotation prob is a bitmask value. It must always have a valid value. > > nit: s/prob/prop/ > > > A default NO rotation is equal t

Re: [PATCH] drm/mediatek: Set Rotation default value to 1.

2021-10-25 Thread Sean Paul
On Fri, Oct 22, 2021 at 12:54:02PM -0400, Mark Yacoub wrote: > From: Mark Yacoub > > [Why] > The Rotation prob is a bitmask value. It must always have a valid value. nit: s/prob/prop/ > A default NO rotation is equal to 1 not 0. > > [How] > 1. At the reset hook, call __drm_atomic_helper_plane_

[PATCH] drm/mediatek: Set Rotation default value to 1.

2021-10-22 Thread Mark Yacoub
From: Mark Yacoub [Why] The Rotation prob is a bitmask value. It must always have a valid value. A default NO rotation is equal to 1 not 0. [How] 1. At the reset hook, call __drm_atomic_helper_plane_reset which is called at the initialization of the plane and sets the default value of all planes