Re: [PATCH] drm/mcde: Fix RGB/BGR bug

2020-11-23 Thread Sam Ravnborg
Hi Linus. On Tue, Nov 17, 2020 at 06:54:13PM +0100, Linus Walleij wrote: > I was confused when the graphics came out with blue > penguins on the DPI panel. > > It turns out that the so-called "packed RGB666" mode > on the DSI formatter is incorrect: this mode is the > actual RGB888 mode, and the

Re: [PATCH] drm/mcde: Fix RGB/BGR bug

2020-11-17 Thread Linus Walleij
On Tue, Nov 17, 2020 at 8:24 PM Sam Ravnborg wrote: > > Cc: phone-de...@vger.kernel.org > > Cc: Stephan Gerhold > > Signed-off-by: Linus Walleij > Fixes: ?? It's no regression actually: for the current hardware we just invert the buffers twice and it looks OK. Buffers are declared BGR and the

Re: [PATCH] drm/mcde: Fix RGB/BGR bug

2020-11-17 Thread Sam Ravnborg
Hi Linus On Tue, Nov 17, 2020 at 06:54:13PM +0100, Linus Walleij wrote: > I was confused when the graphics came out with blue > penguins on the DPI panel. > > It turns out that the so-called "packed RGB666" mode > on the DSI formatter is incorrect: this mode is the > actual RGB888 mode, and the m

[PATCH] drm/mcde: Fix RGB/BGR bug

2020-11-17 Thread Linus Walleij
I was confused when the graphics came out with blue penguins on the DPI panel. It turns out that the so-called "packed RGB666" mode on the DSI formatter is incorrect: this mode is the actual RGB888 mode, and the mode called RGB888 is BGR888. The claims that the MCDE had inverse RGB/BGR buffer for