Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-07-26 Thread Dragan Simic
On 2024-07-26 10:54, Qiang Yu wrote: On Fri, Jul 26, 2024 at 4:03 PM Dragan Simic wrote: On 2024-07-26 08:07, Qiang Yu wrote: > Yeah, I agree weakdep is a better choice here. It solves the confusion > of softdep which the depend module is optional. Thanks, I'm glad that you agree. > But I pre

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-07-26 Thread Qiang Yu
On Fri, Jul 26, 2024 at 4:03 PM Dragan Simic wrote: > > Hello Qiang Yu, > > On 2024-07-26 08:07, Qiang Yu wrote: > > Yeah, I agree weakdep is a better choice here. It solves the confusion > > of softdep which the depend module is optional. > > Thanks, I'm glad that you agree. > > > But I prefer us

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-07-26 Thread Dragan Simic
Hello Qiang Yu, On 2024-07-26 08:07, Qiang Yu wrote: Yeah, I agree weakdep is a better choice here. It solves the confusion of softdep which the depend module is optional. Thanks, I'm glad that you agree. But I prefer using weakdep directly instead of creating an aliasing of it which has no

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-07-25 Thread Qiang Yu
Yeah, I agree weakdep is a better choice here. It solves the confusion of softdep which the depend module is optional. But I prefer using weakdep directly instead of creating an aliasing of it which has no actual difference. On Thu, Jul 25, 2024 at 4:21 PM Dragan Simic wrote: > > Hello Qiang, >

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-07-25 Thread Dragan Simic
Hello Qiang, On 2024-06-26 08:49, Dragan Simic wrote: On 2024-06-26 03:11, Qiang Yu wrote: On Wed, Jun 26, 2024 at 2:15 AM Dragan Simic wrote: Just checking, any further thoughts about this patch? I'm OK with this as a temp workaround because it's simple and do no harm even it's not perfect

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-30 Thread Qiang Yu
Applied to drm-misc-next. On Wed, Jun 26, 2024 at 2:49 PM Dragan Simic wrote: > > Hello Qiang, > > On 2024-06-26 03:11, Qiang Yu wrote: > > On Wed, Jun 26, 2024 at 2:15 AM Dragan Simic > > wrote: > >> > >> Hello everyone, > >> > >> Just checking, any further thoughts about this patch? > >> > > I

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-25 Thread Dragan Simic
Hello Qiang, On 2024-06-26 03:11, Qiang Yu wrote: On Wed, Jun 26, 2024 at 2:15 AM Dragan Simic wrote: Hello everyone, Just checking, any further thoughts about this patch? I'm OK with this as a temp workaround because it's simple and do no harm even it's not perfect. If no other better sug

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-25 Thread Qiang Yu
On Wed, Jun 26, 2024 at 2:15 AM Dragan Simic wrote: > > Hello everyone, > > Just checking, any further thoughts about this patch? > I'm OK with this as a temp workaround because it's simple and do no harm even it's not perfect. If no other better suggestion for short term, I'll submit this at week

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-25 Thread Dragan Simic
Hello everyone, Just checking, any further thoughts about this patch? On 2024-06-18 21:22, Dragan Simic wrote: On 2024-06-18 12:33, Dragan Simic wrote: On 2024-06-18 10:13, Maxime Ripard wrote: On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-18 Thread Dragan Simic
On 2024-06-18 12:33, Dragan Simic wrote: Hello Qiang and Maxime, On 2024-06-18 10:13, Maxime Ripard wrote: On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > I see the problem that initramfs need to build a module dependency chain, > b

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-18 Thread Dragan Simic
Hello Qiang and Maxime, On 2024-06-18 10:13, Maxime Ripard wrote: On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > I see the problem that initramfs need to build a module dependency chain, > but lima does not call any symbol from simp

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-18 Thread Maxime Ripard
On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: > On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > > > I see the problem that initramfs need to build a module dependency chain, > > but lima does not call any symbol from simpleondemand governor module. > > > > softdep module seems to be

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-18 Thread Qiang Yu
On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > I see the problem that initramfs need to build a module dependency chain, > but lima does not call any symbol from simpleondemand governor module. > > softdep module seems to be optional while our dependency is hard one, > can we just add MODULE

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-17 Thread Qiang Yu
I see the problem that initramfs need to build a module dependency chain, but lima does not call any symbol from simpleondemand governor module. softdep module seems to be optional while our dependency is hard one, can we just add MODULE_INFO(depends, _depends), or create a new macro called MODULE

[PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-17 Thread Dragan Simic
Lima DRM driver uses devfreq to perform DVFS, while using simple_ondemand devfreq governor by default. This causes driver initialization to fail on boot when simple_ondemand governor isn't built into the kernel statically, as a result of the missing module dependency and, consequently, the require