Re: [PATCH] drm/lima: Fix dev_pm_opp_set_config in case of missing regulator

2022-10-26 Thread Erico Nunes
Hello, On Wed, Oct 26, 2022 at 11:36 AM Viresh Kumar wrote: > You can directly call devm_pm_opp_set_clkname() and > devm_pm_opp_set_regulators(), like it was done before my patch, for > single configurations. So basically a simple revert of my commit, with > additional comments you added above.

Re: [PATCH] drm/lima: Fix dev_pm_opp_set_config in case of missing regulator

2022-10-26 Thread Viresh Kumar
On 26-10-22, 10:39, Erico Nunes wrote: > Commit d8c32d3971e4 ("drm/lima: Migrate to dev_pm_opp_set_config()") > introduced a regression as it may undo the clk_names setting in case > the optional regulator is missing. This resulted in test and performance > regressions with lima. > > Restore the o

[PATCH] drm/lima: Fix dev_pm_opp_set_config in case of missing regulator

2022-10-26 Thread Erico Nunes
Commit d8c32d3971e4 ("drm/lima: Migrate to dev_pm_opp_set_config()") introduced a regression as it may undo the clk_names setting in case the optional regulator is missing. This resulted in test and performance regressions with lima. Restore the old behavior where clk_names is set separately so it