Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-21 Thread Robert Beckett
On Thu, 2019-06-20 at 17:53 +0100, Robert Beckett wrote: > On Thu, 2019-06-20 at 18:29 +0200, Daniel Vetter wrote: > > On Thu, Jun 20, 2019 at 3:30 PM Robert Beckett > > wrote: > > > On Thu, 2019-06-20 at 14:32 +0200, Daniel Vetter wrote: > > > > On Thu, Jun 20, 2019 at 12:12:13PM +0100, Robert Be

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-20 Thread Robert Beckett
On Thu, 2019-06-20 at 18:29 +0200, Daniel Vetter wrote: > On Thu, Jun 20, 2019 at 3:30 PM Robert Beckett > wrote: > > On Thu, 2019-06-20 at 14:32 +0200, Daniel Vetter wrote: > > > On Thu, Jun 20, 2019 at 12:12:13PM +0100, Robert Beckett wrote: > > > > On Thu, 2019-06-20 at 10:50 +0200, Daniel Vett

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-20 Thread Daniel Vetter
On Thu, Jun 20, 2019 at 3:30 PM Robert Beckett wrote: > On Thu, 2019-06-20 at 14:32 +0200, Daniel Vetter wrote: > > On Thu, Jun 20, 2019 at 12:12:13PM +0100, Robert Beckett wrote: > > > On Thu, 2019-06-20 at 10:50 +0200, Daniel Vetter wrote: > > > > On Wed, Jun 19, 2019 at 11:40 AM Philipp Zabel <

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-20 Thread Robert Beckett
On Thu, 2019-06-20 at 14:32 +0200, Daniel Vetter wrote: > On Thu, Jun 20, 2019 at 12:12:13PM +0100, Robert Beckett wrote: > > On Thu, 2019-06-20 at 10:50 +0200, Daniel Vetter wrote: > > > On Wed, Jun 19, 2019 at 11:40 AM Philipp Zabel < > > > p.za...@pengutronix.de> wrote: > > > > > > > > Hi Rober

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-20 Thread Daniel Vetter
On Thu, Jun 20, 2019 at 12:12:13PM +0100, Robert Beckett wrote: > On Thu, 2019-06-20 at 10:50 +0200, Daniel Vetter wrote: > > On Wed, Jun 19, 2019 at 11:40 AM Philipp Zabel < > > p.za...@pengutronix.de> wrote: > > > > > > Hi Robert, > > > > > > thank you for the patch. > > > > > > On Tue, 2019-0

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-20 Thread Philipp Zabel
Hi Robert, Daniel, On Thu, 2019-06-20 at 12:12 +0100, Robert Beckett wrote: > On Thu, 2019-06-20 at 10:50 +0200, Daniel Vetter wrote: > > On Wed, Jun 19, 2019 at 11:40 AM Philipp Zabel < > > p.za...@pengutronix.de> wrote: > > > > > > Hi Robert, > > > > > > thank you for the patch. > > > > > > O

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-20 Thread Robert Beckett
On Thu, 2019-06-20 at 10:50 +0200, Daniel Vetter wrote: > On Wed, Jun 19, 2019 at 11:40 AM Philipp Zabel < > p.za...@pengutronix.de> wrote: > > > > Hi Robert, > > > > thank you for the patch. > > > > On Tue, 2019-06-18 at 16:50 +0100, Robert Beckett wrote: > > > Notify drm core before sending pe

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-20 Thread Daniel Vetter
On Wed, Jun 19, 2019 at 11:40 AM Philipp Zabel wrote: > > Hi Robert, > > thank you for the patch. > > On Tue, 2019-06-18 at 16:50 +0100, Robert Beckett wrote: > > Notify drm core before sending pending events during crtc disable. > > This fixes the first event after disable having an old stale tim

Re: [PATCH] drm/imx: correct order of crtc disable

2019-06-19 Thread Philipp Zabel
Hi Robert, thank you for the patch. On Tue, 2019-06-18 at 16:50 +0100, Robert Beckett wrote: > Notify drm core before sending pending events during crtc disable. > This fixes the first event after disable having an old stale timestamp > by having drm_crtc_vblank_off update the timestamp to now. >

[PATCH] drm/imx: correct order of crtc disable

2019-06-18 Thread Robert Beckett
Notify drm core before sending pending events during crtc disable. This fixes the first event after disable having an old stale timestamp by having drm_crtc_vblank_off update the timestamp to now. This was seen while debugging weston log message: Warning: computed repaint delay is insane: -8212 ms