Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-04-16 Thread Javier Martinez Canillas
Uwe Kleine-König writes: [...] >> >> This issue was already fixed by Dave in commit b24343eaceed ("Merge tag >> 'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc >> into drm-next"). > > FTR: s/b24343eaceed/c6265f5c2f50/ > Ups indeed. I pasted the wrong commit :) > Thank

Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-04-16 Thread Uwe Kleine-König
Hello Javier, On Sat, Apr 15, 2023 at 11:47:22PM +0200, Javier Martinez Canillas wrote: > Javier Martinez Canillas writes: > > > Uwe Kleine-König writes: > > > > Hello Uwe, > > > >> Hello, > >> > >> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: > >>> The driver needs the inc

Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-04-15 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Uwe Kleine-König writes: > > Hello Uwe, > >> Hello, >> >> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: >>> The driver needs the include . WIth CONFIG_OF enabled >> > > Reviewed-by: Javier Martinez Canillas > > >> Just noticed: s/WIth/With/

Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-04-15 Thread Javier Martinez Canillas
Uwe Kleine-König writes: Hello Uwe, > Hello, > > On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: >> The driver needs the include . WIth CONFIG_OF enabled > Reviewed-by: Javier Martinez Canillas > Just noticed: s/WIth/With/. Assuming no further review comments make a > v2 ne

[PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-03-20 Thread Uwe Kleine-König
The driver needs the include . WIth CONFIG_OF enabled this is provided by a conditional include in . To fix building the lcdc driver with CONFIG_OF=n, include explicitly. Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25") Reported-by: kernel test robot Link: https://lore.kerne

Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-03-20 Thread Uwe Kleine-König
Hello, On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: > The driver needs the include . WIth CONFIG_OF enabled Just noticed: s/WIth/With/. Assuming no further review comments make a v2 necessary: Should I resend for that, or can you fixup when you apply this patch? Best regards