Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-05 Thread Lucas De Marchi
On Tue, Oct 05, 2021 at 09:19:39AM +0300, Dan Carpenter wrote: On Mon, Oct 04, 2021 at 01:52:27PM -0700, Lucas De Marchi wrote: Cc'ing Dan Carpenter On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote: > On Fri, 01 Oct 2021, Chris Wilson wrote: > > Quoting Lucas De Marchi (2021-10-01 0

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-04 Thread Dan Carpenter
On Mon, Oct 04, 2021 at 01:52:27PM -0700, Lucas De Marchi wrote: > Cc'ing Dan Carpenter > > On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote: > > On Fri, 01 Oct 2021, Chris Wilson wrote: > > > Quoting Lucas De Marchi (2021-10-01 08:40:41) > > > > When trying to bring IS_ACTIVE to linux

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-04 Thread Lucas De Marchi
Cc'ing Dan Carpenter On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote: On Fri, 01 Oct 2021, Chris Wilson wrote: Quoting Lucas De Marchi (2021-10-01 08:40:41) When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't provide much value just encapsulating it in a boolea

Re: [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread kernel test robot
Hi Lucas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.15-rc3 next-20210823] [cannot apply to airlied/drm-next] [If your patch is applied

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Lucas De Marchi
On Fri, Oct 01, 2021 at 12:57:13PM +0300, Jani Nikula wrote: On Fri, 01 Oct 2021, Chris Wilson wrote: Quoting Lucas De Marchi (2021-10-01 08:40:41) When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't provide much value just encapsulating it in a boolean context. So I also a

Re: [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread kernel test robot
Hi Lucas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next v5.15-rc3 next-20210922] [cannot apply to airlied/drm-next] [If your patch is

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Chris Wilson
Quoting Lucas De Marchi (2021-10-01 08:40:41) > When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't > provide much value just encapsulating it in a boolean context. So I also > added the support for handling undefined macros as the IS_ENABLED() > counterpart. However the feedbac

Re: [Intel-gfx] [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Jani Nikula
On Fri, 01 Oct 2021, Chris Wilson wrote: > Quoting Lucas De Marchi (2021-10-01 08:40:41) >> When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't >> provide much value just encapsulating it in a boolean context. So I also >> added the support for handling undefined macros as the

Re: [PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Jani Nikula
On Fri, 01 Oct 2021, Lucas De Marchi wrote: > When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't > provide much value just encapsulating it in a boolean context. So I also > added the support for handling undefined macros as the IS_ENABLED() > counterpart. However the feedback

[PATCH] drm/i915: remove IS_ACTIVE

2021-10-01 Thread Lucas De Marchi
When trying to bring IS_ACTIVE to linux/kconfig.h I thought it wouldn't provide much value just encapsulating it in a boolean context. So I also added the support for handling undefined macros as the IS_ENABLED() counterpart. However the feedback received from Masahiro Yamada was that it is too ugl