On Thu, Jun 16, 2011 at 04:47:53PM +0100, Chris Wilson wrote:
> On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes virtuousgeek.org> wrote:
> > On Thu, 16 Jun 2011 15:28:46 +0200
> > Wolfram Sang wrote:
> > > How about BUG_ON(!ptr) in the init-routine for a bit more grace? And/or
> > > a warning in
On Sun, 19 Jun 2011 21:22:11 +0200, Wolfram Sang
wrote:
> On Thu, Jun 16, 2011 at 04:47:53PM +0100, Chris Wilson wrote:
> > On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes > virtuousgeek.org> wrote:
> > > On Thu, 16 Jun 2011 15:28:46 +0200
> > > Wolfram Sang wrote:
> > > > How about BUG_ON(!pt
On Sun, 19 Jun 2011 21:22:11 +0200, Wolfram Sang wrote:
> On Thu, Jun 16, 2011 at 04:47:53PM +0100, Chris Wilson wrote:
> > On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes
> > wrote:
> > > On Thu, 16 Jun 2011 15:28:46 +0200
> > > Wolfram Sang wrote:
> > > > How about BUG_ON(!ptr) in the init-r
On Thu, Jun 16, 2011 at 04:47:53PM +0100, Chris Wilson wrote:
> On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes
> wrote:
> > On Thu, 16 Jun 2011 15:28:46 +0200
> > Wolfram Sang wrote:
> > > How about BUG_ON(!ptr) in the init-routine for a bit more grace? And/or
> > > a warning in the else-block
On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes
wrote:
> On Thu, 16 Jun 2011 15:28:46 +0200
> Wolfram Sang wrote:
> > How about BUG_ON(!ptr) in the init-routine for a bit more grace? And/or
> > a warning in the else-block? It seems to happen to users...
>
> Yeah, a BUG_ON would be fine.
if (W
> > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > functions) unconditionally calls the newly created
> > init_clock_gating-pointer. There is one case, however, where it does
> > not get set:
> >
> > if (HAS_PCH_SPLIT(dev)) {
> > ...
> > } else
> > dev_pr
On Thu, 16 Jun 2011 08:15:57 -0700, Jesse Barnes
wrote:
> On Thu, 16 Jun 2011 15:28:46 +0200
> Wolfram Sang wrote:
> > How about BUG_ON(!ptr) in the init-routine for a bit more grace? And/or
> > a warning in the else-block? It seems to happen to users...
>
> Yeah, a BUG_ON would be fine.
if (W
On Thu, 16 Jun 2011 15:28:46 +0200
Wolfram Sang wrote:
> > > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > > functions) unconditionally calls the newly created
> > > init_clock_gating-pointer. There is one case, however, where it does
> > > not get set:
> > >
> > > if (HA
On Thu, 16 Jun 2011 15:28:46 +0200
Wolfram Sang wrote:
> > > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > > functions) unconditionally calls the newly created
> > > init_clock_gating-pointer. There is one case, however, where it does
> > > not get set:
> > >
> > > if (HA
> > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > functions) unconditionally calls the newly created
> > init_clock_gating-pointer. There is one case, however, where it does
> > not get set:
> >
> > if (HAS_PCH_SPLIT(dev)) {
> > ...
> > } else
> > dev_pr
Commit 6067aa (drm/i915: split clock gating init into per-chipset
functions) unconditionally calls the newly created
init_clock_gating-pointer. There is one case, however, where it does
not get set:
if (HAS_PCH_SPLIT(dev)) {
...
} else
dev_priv->display.update_wm =
On Thu, 16 Jun 2011 00:24:39 +0200
Wolfram Sang wrote:
> Commit 6067aa (drm/i915: split clock gating init into per-chipset
> functions) unconditionally calls the newly created
> init_clock_gating-pointer. There is one case, however, where it does
> not get set:
>
> if (HAS_PCH_SPLIT(dev)) {
>
Commit 6067aa (drm/i915: split clock gating init into per-chipset
functions) unconditionally calls the newly created
init_clock_gating-pointer. There is one case, however, where it does
not get set:
if (HAS_PCH_SPLIT(dev)) {
...
} else
dev_priv->display.update_wm =
On Thu, 16 Jun 2011 00:24:39 +0200
Wolfram Sang wrote:
> Commit 6067aa (drm/i915: split clock gating init into per-chipset
> functions) unconditionally calls the newly created
> init_clock_gating-pointer. There is one case, however, where it does
> not get set:
>
> if (HAS_PCH_SPLIT(dev)) {
>
14 matches
Mail list logo
