Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-25 Thread Karol Herbst
On Wed, Aug 24, 2022 at 7:50 PM Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > wrote: > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are routed to dGFX, and

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-24 Thread Ville Syrjälä
On Wed, Aug 17, 2022 at 11:04:21AM +0800, Kai-Heng Feng wrote: > On Wed, Aug 17, 2022 at 9:49 AM Karol Herbst wrote: > > > > On Wed, Aug 17, 2022 at 3:18 AM Kai-Heng Feng > > wrote: > > > > > > On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > > > > > > > On Tue, Aug 16, 2022 at 4:53 AM Ka

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-24 Thread Kai-Heng Feng
On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula wrote: > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as result. > > > > To switch the D

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-24 Thread Kai-Heng Feng
On Sat, Aug 20, 2022 at 1:01 AM Karol Herbst wrote: > > On Thu, Aug 18, 2022 at 2:09 PM Lukas Wunner wrote: > > > > On Tue, Aug 16, 2022 at 11:06:18AM +0300, Jani Nikula wrote: > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-19 Thread Karol Herbst
On Thu, Aug 18, 2022 at 2:09 PM Lukas Wunner wrote: > > On Tue, Aug 16, 2022 at 11:06:18AM +0300, Jani Nikula wrote: > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are routed to dGFX, and

Re: [External] Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-18 Thread Mark Pearson
On 2022-08-17 13:56, Lyude Paul wrote: > Adding Mark Pearson from Lenovo to this, Mark for reference the original patch > is here: > > https://patchwork.freedesktop.org/patch/497807/?series=107312&rev=1>> > Comments from me down below > > On Wed, 2022-08-17 at 09:02 +0800, Kai-Heng Feng wrot

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-18 Thread Lukas Wunner
On Tue, Aug 16, 2022 at 11:06:18AM +0300, Jani Nikula wrote: > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as result. > > > > To switc

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-17 Thread Lyude Paul
Adding Mark Pearson from Lenovo to this, Mark for reference the original patch is here: https://patchwork.freedesktop.org/patch/497807/?series=107312&rev=1 Comments from me down below On Wed, 2022-08-17 at 09:02 +0800, Kai-Heng Feng wrote: > On Wed, Aug 17, 2022 at 2:24 AM Lyude Paul wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-17 Thread Ville Syrjälä
On Wed, Aug 17, 2022 at 08:15:58PM +0800, Kai-Heng Feng wrote: > On Wed, Aug 17, 2022 at 7:59 PM Ville Syrjälä > wrote: > > [snipped] > > > I had a quick trawl through some Windows stuff for this and > > it does seem to do a few extra checks: > > - platform must be TGL-H (nothing else has the DP

Re: [Intel-gfx] [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-17 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 7:59 PM Ville Syrjälä wrote: [snipped] > I had a quick trawl through some Windows stuff for this and > it does seem to do a few extra checks: > - platform must be TGL-H (nothing else has the DPin stuff I guess) > - OpRegion header must indicate dGPU presence Is the dGPU

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 9:49 AM Karol Herbst wrote: > > On Wed, Aug 17, 2022 at 3:18 AM Kai-Heng Feng > wrote: > > > > On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > > > > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > > > wrote: > > > > > > > > On mobile workstations like HP ZBook

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Karol Herbst
On Wed, Aug 17, 2022 at 3:18 AM Kai-Heng Feng wrote: > > On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > > wrote: > > > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are r

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:50 AM Karol Herbst wrote: > > On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng > wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as result. > > >

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:36 AM Lyude Paul wrote: > > On Tue, 2022-08-16 at 14:24 -0400, Lyude Paul wrote: > > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > > wrote: > > > > > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > >

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Kai-Heng Feng
On Wed, Aug 17, 2022 at 2:24 AM Lyude Paul wrote: > > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > wrote: > > > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can s

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Karol Herbst
On Tue, Aug 16, 2022 at 4:53 AM Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > dGFX so external monitors are routed to dGFX, and more monitors can be > supported as result. > > To switch the DP-IN to dGFX, the driver needs to invoke _DSM functio

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Lyude Paul
On Tue, 2022-08-16 at 14:24 -0400, Lyude Paul wrote: > On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > > wrote: > > > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Lyude Paul
On Tue, 2022-08-16 at 19:29 +0800, Kai-Heng Feng wrote: > On Tue, Aug 16, 2022 at 4:06 PM Jani Nikula > wrote: > > > > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > > dGFX so external monitors are routed to dGFX, and

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-16 Thread Jani Nikula
On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > dGFX so external monitors are routed to dGFX, and more monitors can be > supported as result. > > To switch the DP-IN to dGFX, the driver needs to invoke _DSM function 20 > on int

[PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-15 Thread Kai-Heng Feng
On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to dGFX so external monitors are routed to dGFX, and more monitors can be supported as result. To switch the DP-IN to dGFX, the driver needs to invoke _DSM function 20 on intel_dsm_guid2. This method is described in Intel docume