Re: [Intel-gfx] [PATCH] drm/i915: Mark expected switch fall-throughs

Hi Gustavo, could you please rebase on top of drm-tip and resend it please? Thanks, Rodrigo. On Mon, Jul 22, 2019 at 01:12:44PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes

Re: [PATCH] drm/i915: Mark expected switch fall-throughs

On Mon, Jul 22, 2019 at 01:12:44PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/gpu/drm/i915/gem/i915_gem_mman.c: In function ‘i915_gem_fa

[PATCH] drm/i915: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/gpu/drm/i915/gem/i915_gem_mman.c: In function ‘i915_gem_fault’: drivers/gpu/drm/i915/gem/i915_gem_mman.c:342:6: warning: this statement may

Re: [PATCH] drm/i915: Mark expected switch fall-throughs

On 07/05/2018 08:43 AM, Jani Nikula wrote: > On Fri, 29 Jun 2018, Jani Nikula wrote: >> On Thu, 28 Jun 2018, "Gustavo A. R. Silva" wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >>> >>> Addresses-Coverity-ID: 141432 >>

Re: [PATCH] drm/i915: Mark expected switch fall-throughs

On Fri, 29 Jun 2018, Jani Nikula wrote: > On Thu, 28 Jun 2018, "Gustavo A. R. Silva" wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> Addresses-Coverity-ID: 141432 >> Addresses-Coverity-ID: 141433 >> Addresses-Coverity

Re: [PATCH] drm/i915: Mark expected switch fall-throughs

On Thu, 28 Jun 2018, "Gustavo A. R. Silva" wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 141432 > Addresses-Coverity-ID: 141433 > Addresses-Coverity-ID: 141434 > Addresses-Coverity-ID: 141435 > Add

[PATCH] drm/i915: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 141432 Addresses-Coverity-ID: 141433 Addresses-Coverity-ID: 141434 Addresses-Coverity-ID: 141435 Addresses-Coverity-ID: 141436 Addresses-Coverity-ID: 1357360 Addresse

Re: [PATCH] drm/i915: Mark expected switch fall-throughs

Hi Joonas, Quoting Joonas Lahtinen : On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. I have to say I'm totally not sold on regexps matching comment contents. Was somethi

Re: [Intel-gfx] [PATCH] drm/i915: Mark expected switch fall-throughs

On Mon, Dec 4, 2017 at 4:20 PM, Gustavo A. R. Silva wrote: > Hi Joonas, > > Quoting Joonas Lahtinen : > >> On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote: >>> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >> >> >>

Re: [PATCH] drm/i915: Mark expected switch fall-throughs

On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. I have to say I'm totally not sold on regexps matching comment contents. Was something more explicit ever considered? Like:

[PATCH] drm/i915: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 141432 Addresses-Coverity-ID: 141433 Addresses-Coverity-ID: 141434 Addresses-Coverity-ID: 141435 Addresses-Coverity-ID: 141436 Addresses-Coverity-ID: 1357360 Addresse