Re: [PATCH] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

2024-07-26 Thread Jani Nikula
On Thu, 25 Jul 2024, Nikita Zhandarovich wrote: > Hi, > > On 7/25/24 01:17, Jani Nikula wrote: >> On Wed, 24 Jul 2024, Nikita Zhandarovich wrote: >>> On the off chance that clock value ends up being too high (by means >>> of skl_ddi_calculate_wrpll() having benn called with big enough >>> value o

Re: [PATCH] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

2024-07-25 Thread Nikita Zhandarovich
Hi, On 7/25/24 01:17, Jani Nikula wrote: > On Wed, 24 Jul 2024, Nikita Zhandarovich wrote: >> On the off chance that clock value ends up being too high (by means >> of skl_ddi_calculate_wrpll() having benn called with big enough >> value of crtc_state->port_clock * 1000), one possible consequence

Re: [PATCH] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

2024-07-25 Thread Jani Nikula
On Wed, 24 Jul 2024, Nikita Zhandarovich wrote: > On the off chance that clock value ends up being too high (by means > of skl_ddi_calculate_wrpll() having benn called with big enough > value of crtc_state->port_clock * 1000), one possible consequence > may be that the result will not be able to f

[PATCH] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

2024-07-24 Thread Nikita Zhandarovich
On the off chance that clock value ends up being too high (by means of skl_ddi_calculate_wrpll() having benn called with big enough value of crtc_state->port_clock * 1000), one possible consequence may be that the result will not be able to fit into signed int. Fix this, albeit unlikely, issue by