Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will at

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:38 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > > When converting to folios the cleanup path of shmem_get_pages() was > > > missed. When a DMA remap fails a

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will attempt t

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 09:36:42AM -0500, Brian Geffon wrote: > On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä > wrote: > > > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > > When converting to folios the cleanup path of shmem_get_pages() was > > > missed. When a DMA remap fail

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 04:24:26PM +0200, Ville Syrjälä wrote: > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will at

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
On Thu, Jan 16, 2025 at 9:24 AM Ville Syrjälä wrote: > > On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > > When converting to folios the cleanup path of shmem_get_pages() was > > missed. When a DMA remap fails and the max segment size is greater than > > PAGE_SIZE it will attempt t

Re: [PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Ville Syrjälä
On Thu, Jan 16, 2025 at 08:56:36AM -0500, Brian Geffon wrote: > When converting to folios the cleanup path of shmem_get_pages() was > missed. When a DMA remap fails and the max segment size is greater than > PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment > size. The cleanup

[PATCH] drm/i915: Fix page cleanup on DMA remap failure

2025-01-16 Thread Brian Geffon
When converting to folios the cleanup path of shmem_get_pages() was missed. When a DMA remap fails and the max segment size is greater than PAGE_SIZE it will attempt to retry the remap with a PAGE_SIZEd segment size. The cleanup code isn't properly using the folio apis and as a result isn't handlin