[PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

2012-08-05 Thread Jesper Juhl
On Sun, 5 Aug 2012, Daniel Vetter wrote: > On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote: > > If the allocation of 'buf' succeeds but the allocation of 'msgs' fails > > we'll return false and leak 'buf' when it goes out of scope. > > > > Signed-off-by: Jesper Juhl > > I've already

[PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

2012-08-05 Thread Daniel Vetter
On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote: > If the allocation of 'buf' succeeds but the allocation of 'msgs' fails > we'll return false and leak 'buf' when it goes out of scope. > > Signed-off-by: Jesper Juhl I've already merged a similar patch from Alan Cox for -fixes, should

Re: [PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

2012-08-05 Thread Jesper Juhl
On Sun, 5 Aug 2012, Daniel Vetter wrote: > On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote: > > If the allocation of 'buf' succeeds but the allocation of 'msgs' fails > > we'll return false and leak 'buf' when it goes out of scope. > > > > Signed-off-by: Jesper Juhl > > I've already

Re: [PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

2012-08-05 Thread Daniel Vetter
On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote: > If the allocation of 'buf' succeeds but the allocation of 'msgs' fails > we'll return false and leak 'buf' when it goes out of scope. > > Signed-off-by: Jesper Juhl I've already merged a similar patch from Alan Cox for -fixes, should

[PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

2012-07-31 Thread Jesper Juhl
If the allocation of 'buf' succeeds but the allocation of 'msgs' fails we'll return false and leak 'buf' when it goes out of scope. Signed-off-by: Jesper Juhl --- drivers/gpu/drm/i915/intel_sdvo.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) note: compile tested only due t

[PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

2012-07-31 Thread Jesper Juhl
If the allocation of 'buf' succeeds but the allocation of 'msgs' fails we'll return false and leak 'buf' when it goes out of scope. Signed-off-by: Jesper Juhl --- drivers/gpu/drm/i915/intel_sdvo.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) note: compile tested only due t