Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Jani Nikula
On Fri, 17 Jan 2020, Andi Shyti wrote: > Hi Jani, > >> >> Reported-by: Hulk Robot >> > >> > I've never been a fan of non human accounts, we had this discussion >> > already in a different mailing list. Could you please find a >> > different way of giving credit to your CI system? >> >> I don't a

Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Andi Shyti
Hi Jani, > >> Reported-by: Hulk Robot > > > > I've never been a fan of non human accounts, we had this discussion > > already in a different mailing list. Could you please find a > > different way of giving credit to your CI system? > > I don't actually mind for Reported-by credits. The history

Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Jani Nikula
On Fri, 17 Jan 2020, Andi Shyti wrote: > Hi Zhang, > > On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote: >> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error >> capture"), function 'i915_error_state_store' was defined and used with >> only one parameter. >> >> But

Re: [PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Andi Shyti
Hi Zhang, On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote: > Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error > capture"), function 'i915_error_state_store' was defined and used with > only one parameter. > > But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this funct

[PATCH] drm/i915: Fix i915_error_state_store error defination

2020-01-17 Thread Zhang Xiaoxu
Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error capture"), function 'i915_error_state_store' was defined and used with only one parameter. But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined with two parameter. This may lead compile error. This patch fix it