Re: [PATCH] drm/i915: Add VM_DONTEXPAND to exported buffers

2025-01-10 Thread Krzysztof Karas
Hi Jacek, > >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c > >> @@ -110,6 +110,7 @@ static int i915_gem_dmabuf_mmap(struct dma_buf > >> *dma_buf, struct vm_area_struct * > >>if (ret) > >>return ret; > >> > >> + vm_flags_set(vma, VM_DONTEXPAND); > >>vma_set_file(vma, ob

Re: [PATCH] drm/i915: Add VM_DONTEXPAND to exported buffers

2025-01-09 Thread Jacek Lawrynowicz
Sure, the test does the following: 1. Create a Vulkan buffer using VK_STRUCTURE_TYPE_EXPORT_MEMORY_ALLOCATE_INFO and VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT 2. Get Vulkan buffer FD using vkGetMemoryFdKHR() 3. Import the Vulcan buffer to intel_vpu using DRM_IOCTL_PRIME_FD_TO_HANDLE 4. Call m

Re: [PATCH] drm/i915: Add VM_DONTEXPAND to exported buffers

2025-01-09 Thread Jacek Lawrynowicz
Hi, On 1/9/2025 12:22 PM, Krzysztof Karas wrote: > Hi Jacek, > > On 2025-01-08 at 11:53:46 +0100, Jacek Lawrynowicz wrote: >> drm_gem_mmap_obj() expects VM_DONTEXPAND flag to be set after mmap >> callback is executed. Set this flag at the end of i915_gem_dmabuf_mmap() >> to prevent WARN on mmap i

Re: [PATCH] drm/i915: Add VM_DONTEXPAND to exported buffers

2025-01-09 Thread Joonas Lahtinen
Hi, Could you elaborate a bit more on which testcase or usecase this pops up with? The check has been in place since 2019 so quite surprising that it's only popping up now. Regards, Joonas Quoting Jacek Lawrynowicz (2025-01-08 12:53:46) > drm_gem_mmap_obj() expects VM_DONTEXPAND flag to be set

Re: [PATCH] drm/i915: Add VM_DONTEXPAND to exported buffers

2025-01-09 Thread Krzysztof Karas
Hi Jacek, On 2025-01-08 at 11:53:46 +0100, Jacek Lawrynowicz wrote: > drm_gem_mmap_obj() expects VM_DONTEXPAND flag to be set after mmap > callback is executed. Set this flag at the end of i915_gem_dmabuf_mmap() > to prevent WARN on mmap in buffers imported from i915 e.g., ... > +++ b/drivers/gpu/

[PATCH] drm/i915: Add VM_DONTEXPAND to exported buffers

2025-01-08 Thread Jacek Lawrynowicz
drm_gem_mmap_obj() expects VM_DONTEXPAND flag to be set after mmap callback is executed. Set this flag at the end of i915_gem_dmabuf_mmap() to prevent WARN on mmap in buffers imported from i915 e.g., [ 283.623215] WARNING: CPU: 1 PID: 12693 at drivers/gpu/drm/drm_gem.c:1087 drm_gem_mmap_obj+0x19