Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-20 Thread Andi Shyti
Hi Janusz, > > > > > > + > > > > > > cond_resched(); > > > > > > > > > > > > - if (intel_gt_wait_for_idle(gt, HZ * 3) == -ETIME) { > > > > > > + if (intel_gt_wait_for_idle(gt, HZ * timeout_ms / 500) > > > > > > == -ETIME) { > > > > > > > > > > where is this 500

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-20 Thread Andi Shyti
Hi Janusz, > > > > > + > > > > > cond_resched(); > > > > > > > > > > - if (intel_gt_wait_for_idle(gt, HZ * 3) == -ETIME) { > > > > > + if (intel_gt_wait_for_idle(gt, HZ * timeout_ms / 500) > > > > > == - > > > ETIME) { > > > > > > > > where is this 500 com

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-20 Thread Janusz Krzysztofik
Hi Andi, On Tuesday, 17 December 2024 19:00:40 CET Janusz Krzysztofik wrote: > Hi Andi, > > On Tuesday, 17 December 2024 18:12:08 CET Andi Shyti wrote: > > Hi Janusz, > > > > ... > > > > > > > + > > > > > cond_resched(); > > > > > > > > > > - if (intel_gt_wait_for_id

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-17 Thread Janusz Krzysztofik
Hi Andi, On Tuesday, 17 December 2024 18:12:08 CET Andi Shyti wrote: > Hi Janusz, > > ... > > > > > + > > > > cond_resched(); > > > > > > > > - if (intel_gt_wait_for_idle(gt, HZ * 3) == -ETIME) { > > > > + if (intel_gt_wait_for_idle(gt, HZ * timeout_

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-17 Thread Andi Shyti
Hi Janusz, ... > > > + > > > cond_resched(); > > > > > > - if (intel_gt_wait_for_idle(gt, HZ * 3) == -ETIME) { > > > + if (intel_gt_wait_for_idle(gt, HZ * timeout_ms / 500) == - > ETIME) { > > > > where is this 500 coming from? > > / 1000 would convert it to seconds

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-16 Thread Janusz Krzysztofik
Hi Andi, Thanks for review. On Monday, 16 December 2024 14:26:58 CET Andi Shyti wrote: > Hi Janusz, > > ... > > > for_each_gt(gt, i915, i) { > > + struct intel_engine_cs *engine; > > + unsigned long timeout_ms = 0; > > + unsigned int id; > > + > > i

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-16 Thread Andi Shyti
Hi Janusz, ... > for_each_gt(gt, i915, i) { > + struct intel_engine_cs *engine; > + unsigned long timeout_ms = 0; > + unsigned int id; > + > if (intel_gt_is_wedged(gt)) > ret = -EIO; > > + for_each_engine(

[PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-13 Thread Janusz Krzysztofik
Many selftests call igt_flush_test() on cleanup. With default preemption timeout of compute engines raised to 7.5 seconds, hardcoded flush timeout of 3 seconds is too short. That results in GPU forcibly wedged and kernel taineted, then IGT abort triggered. CI BAT runs loose a part of their expec