Re: [PATCH] drm/i915/psr: simplify enable_psr handling

2018-12-24 Thread Daniel Vetter
On Fri, Dec 21, 2018 at 8:53 PM Ross Zwisler wrote: > > On Fri, Dec 21, 2018 at 11:23:07AM -0800, Dhinakaran Pandiyan wrote: > > On Fri, 2018-12-21 at 10:23 -0700, Ross Zwisler wrote: > > > The following commit: > > > > > > commit 2bdd045e3a30 ("drm/i915/psr: Check if VBT says PSR can be > > > ena

[PATCH] drm/i915/psr: simplify enable_psr handling

2018-12-23 Thread Ross Zwisler
The following commit: commit 2bdd045e3a30 ("drm/i915/psr: Check if VBT says PSR can be enabled.") added some code with no usable functionality. Regardless of how the psr default is set up in the BDB_DRIVER_FEATURES section, if the enable_psr module parameter isn't specified it defaults to 0. Re

Re: [PATCH] drm/i915/psr: simplify enable_psr handling

2018-12-23 Thread Ross Zwisler
On Fri, Dec 21, 2018 at 11:23:07AM -0800, Dhinakaran Pandiyan wrote: > On Fri, 2018-12-21 at 10:23 -0700, Ross Zwisler wrote: > > The following commit: > > > > commit 2bdd045e3a30 ("drm/i915/psr: Check if VBT says PSR can be > > enabled.") > > > > added some code with no usable functionality. Re

Re: [PATCH] drm/i915/psr: simplify enable_psr handling

2018-12-21 Thread Dhinakaran Pandiyan
On Fri, 2018-12-21 at 10:23 -0700, Ross Zwisler wrote: > The following commit: > > commit 2bdd045e3a30 ("drm/i915/psr: Check if VBT says PSR can be > enabled.") > > added some code with no usable functionality. Regardless of how the > psr > default is set up in the BDB_DRIVER_FEATURES section, i