Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Tvrtko Ursulin
On 01/04/2021 11:24, Tamminen, Eero T wrote: Hi, On Thu, 2021-04-01 at 05:54 -0400, Rodrigo Vivi wrote: On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: ... I think it is possible to argue both ways. 1) HAS_RC6 means hardware has RC6 so if we view PMU as very low level we ca

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Tamminen, Eero T
Hi, On Thu, 2021-04-01 at 05:54 -0400, Rodrigo Vivi wrote: > On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: ... > > I think it is possible to argue both ways. > > > > 1) > > HAS_RC6 means hardware has RC6 so if we view PMU as very low level > > we can > > say always export it. >

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Rodrigo Vivi
On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: > > On 01/04/2021 10:19, Rodrigo Vivi wrote: > > On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > RC6 support cannot be simply established by looking at the static device > > > H

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Tvrtko Ursulin
On 01/04/2021 10:19, Rodrigo Vivi wrote: On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin RC6 support cannot be simply established by looking at the static device HAS_RC6() flag. There are cases which disable RC6 at driver load time so use the status of th

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Rodrigo Vivi
On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > RC6 support cannot be simply established by looking at the static device > HAS_RC6() flag. There are cases which disable RC6 at driver load time so > use the status of those check when deciding whether to e

[PATCH] drm/i915/pmu: Check actual RC6 status

2021-03-31 Thread Tvrtko Ursulin
From: Tvrtko Ursulin RC6 support cannot be simply established by looking at the static device HAS_RC6() flag. There are cases which disable RC6 at driver load time so use the status of those check when deciding whether to enumerate the rc6 counter. Signed-off-by: Tvrtko Ursulin Reported-by: Eer