Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-02-02 Thread Gwan-gyeong Mun
On 2/2/23 11:28 AM, Andi Shyti wrote: Hi GG, On Thu, Feb 02, 2023 at 10:22:30AM +0200, Gwan-gyeong Mun wrote: Hi Andi, You gave a lot of explanations, and confirmed that this patch solves the problem, but the root cause of this problem still seems to be unclear. In the logs where this prob

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-02-02 Thread Andi Shyti
Hi GG, On Thu, Feb 02, 2023 at 10:22:30AM +0200, Gwan-gyeong Mun wrote: > Hi Andi, > > You gave a lot of explanations, and confirmed that this patch solves the > problem, but the root cause of this problem still seems to be unclear. > > In the logs where this problem was reported, the logs were

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-02-02 Thread Gwan-gyeong Mun
Hi Andi, You gave a lot of explanations, and confirmed that this patch solves the problem, but the root cause of this problem still seems to be unclear. In the logs where this problem was reported, the logs were output in the following order. link : https://intel-gfx-ci.01.org/tree/drm-ti

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Andi Shyti
Hi Rodrigo, first of all, thanks for looking into this! > > > > > > In the call flow invoked by intel_pcode_init(), I've added brief > > > > > > comments > > > > > > where further clarification is needed in this scenario, and a > > > > > > description of > > > > > > the suspicious scenario at t

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Rodrigo Vivi
On Mon, Jan 30, 2023 at 11:37:29AM -0500, Rodrigo Vivi wrote: > On Mon, Jan 30, 2023 at 05:12:48PM +0100, Andi Shyti wrote: > > Hi Rodrigo, > > > > > > > In the call flow invoked by intel_pcode_init(), I've added brief > > > > > comments > > > > > where further clarification is needed in this sce

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Rodrigo Vivi
On Mon, Jan 30, 2023 at 05:12:48PM +0100, Andi Shyti wrote: > Hi Rodrigo, > > > > > In the call flow invoked by intel_pcode_init(), I've added brief > > > > comments > > > > where further clarification is needed in this scenario, and a > > > > description of > > > > the suspicious scenario at th

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Andi Shyti
Hi Rodrigo, > > > In the call flow invoked by intel_pcode_init(), I've added brief comments > > > where further clarification is needed in this scenario, and a description > > > of > > > the suspicious scenario at the bottom. > > > > > > --

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Rodrigo Vivi
On Mon, Jan 30, 2023 at 09:48:31AM +0100, Andi Shyti wrote: > Hi GG, > > thanks for the deep analysis! > > > Hi Andi, > > In the call flow invoked by intel_pcode_init(), I've added brief comments > > where further clarification is needed in this scenario, and a description of > > the suspicious s

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-30 Thread Andi Shyti
Hi GG, thanks for the deep analysis! > Hi Andi, > In the call flow invoked by intel_pcode_init(), I've added brief comments > where further clarification is needed in this scenario, and a description of > the suspicious scenario at the bottom. > >

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-27 Thread Gwan-gyeong Mun
On 1/27/23 11:00 AM, Andi Shyti wrote: Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan 2

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-27 Thread Andi Shyti
Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: > > > On 1/11/23 5:36 PM, Andi Shyti wrote: > > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: > > > On Wed, 11 Jan 2023, Andi Shyti wrote: > > > >

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-26 Thread Gwan-gyeong Mun
On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan 2023, Andi Shyti wrote: From: Aravind Iddamsetty During module load not all the punit transaction have completed and we might end up timing out, as shown by the following warn

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-16 Thread Andi Shyti
Hi Rodrigo, On Wed, Jan 11, 2023 at 12:06:24PM -0500, Rodrigo Vivi wrote: > On Wed, Jan 11, 2023 at 04:39:36PM +0100, Andi Shyti wrote: > > Hi Rodrigo, > > > > On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote: > > > On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > > > > F

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 04:39:36PM +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote: > > On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > > > From: Aravind Iddamsetty > > > > > > During module load not all the punit transaction

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Jani Nikula
On Wed, 11 Jan 2023, Andi Shyti wrote: > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: >> On Wed, 11 Jan 2023, Andi Shyti wrote: >> > From: Aravind Iddamsetty >> > >> > During module load not all the punit transaction have completed >> > and we might end up timing out, as shown by

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Andi Shyti
Hi Rodrigo, On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote: > On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > > From: Aravind Iddamsetty > > > > During module load not all the punit transaction have completed > > and we might end up timing out, as shown by the followi

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Andi Shyti
On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2023, Andi Shyti wrote: > > From: Aravind Iddamsetty > > > > During module load not all the punit transaction have completed > > and we might end up timing out, as shown by the following > > warning: > > Root cause? >

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > From: Aravind Iddamsetty > > During module load not all the punit transaction have completed > and we might end up timing out, as shown by the following > warning: > >i915 :4d:00.0: drm_WARN_ON_ONCE(timeout_base_ms > 3) > > W

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Jani Nikula
On Wed, 11 Jan 2023, Andi Shyti wrote: > From: Aravind Iddamsetty > > During module load not all the punit transaction have completed > and we might end up timing out, as shown by the following > warning: Root cause? > >i915 :4d:00.0: drm_WARN_ON_ONCE(timeout_base_ms > 3) > > Wait 10 se

[PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Andi Shyti
From: Aravind Iddamsetty During module load not all the punit transaction have completed and we might end up timing out, as shown by the following warning: i915 :4d:00.0: drm_WARN_ON_ONCE(timeout_base_ms > 3) Wait 10 seconds for the punit to settle and complete any outstanding transactio