Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-16 Thread Andi Shyti
Hi Vinay, On Mon, Jan 16, 2023 at 11:35:41AM -0800, Belgaumkar, Vinay wrote: > > On 1/16/2023 10:58 AM, Andi Shyti wrote: > > Hi, > > > > On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote: > > > On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote: > > > > On Thu, 12 Jan 2023 20:26:34 -08

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-16 Thread Belgaumkar, Vinay
On 1/16/2023 10:58 AM, Andi Shyti wrote: Hi, On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote: On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote: On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote: I think the ABI was changed by the patch mentioned in the commit (a8a4f04

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-16 Thread Andi Shyti
Hi, On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote: > > On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote: > > On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote: > > > I think the ABI was changed by the patch mentioned in the commit > > > (a8a4f0467d70). > > The ABI was ori

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-13 Thread Tvrtko Ursulin
On 13/01/2023 03:15, Dixit, Ashutosh wrote: On Thu, 12 Jan 2023 18:27:52 -0800, Vinay Belgaumkar wrote: Reading current root sysfs entries gives a min/max of all GTs. Updating this so we return default (GT0) values when root level sysfs entries are accessed, instead of min/max for the card. T

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-12 Thread Belgaumkar, Vinay
On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote: On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote: I think the ABI was changed by the patch mentioned in the commit (a8a4f0467d70). The ABI was originally changed in 80cf8af17af04 and 56a709cf77468. Yes, you are right. @Andi, did we hav

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-12 Thread Dixit, Ashutosh
On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote: > > I think the ABI was changed by the patch mentioned in the commit > (a8a4f0467d70). The ABI was originally changed in 80cf8af17af04 and 56a709cf77468.

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-12 Thread Belgaumkar, Vinay
On 1/12/2023 7:15 PM, Dixit, Ashutosh wrote: On Thu, 12 Jan 2023 18:27:52 -0800, Vinay Belgaumkar wrote: Reading current root sysfs entries gives a min/max of all GTs. Updating this so we return default (GT0) values when root level sysfs entries are accessed, instead of min/max for the card. T

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-12 Thread Dixit, Ashutosh
On Thu, 12 Jan 2023 18:27:52 -0800, Vinay Belgaumkar wrote: > > Reading current root sysfs entries gives a min/max of all > GTs. Updating this so we return default (GT0) values when root > level sysfs entries are accessed, instead of min/max for the card. > Tests that are not multi GT capable will

[PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-12 Thread Vinay Belgaumkar
Reading current root sysfs entries gives a min/max of all GTs. Updating this so we return default (GT0) values when root level sysfs entries are accessed, instead of min/max for the card. Tests that are not multi GT capable will read incorrect sysfs values without this change on multi-GT platforms