Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-21 Thread Greg Kroah-Hartman
On Wed, May 19, 2021 at 04:21:23PM +0800, Zhenyu Wang wrote: > On 2021.05.19 10:31:18 +0200, Greg Kroah-Hartman wrote: > > On Wed, May 19, 2021 at 04:03:13PM +0800, Zhenyu Wang wrote: > > > On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote: > > > > On Tue, May 18, 2021 at 06:17:05PM +0200, Gre

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-19 Thread Zhenyu Wang
On 2021.05.19 10:31:18 +0200, Greg Kroah-Hartman wrote: > On Wed, May 19, 2021 at 04:03:13PM +0800, Zhenyu Wang wrote: > > On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote: > > > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote: > > > > There is no need to keep the dentry ar

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-19 Thread Greg Kroah-Hartman
On Wed, May 19, 2021 at 04:03:13PM +0800, Zhenyu Wang wrote: > On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote: > > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote: > > > There is no need to keep the dentry around for the debugfs kvmgt cache > > > file, as we can just look

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-19 Thread Zhenyu Wang
On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote: > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote: > > There is no need to keep the dentry around for the debugfs kvmgt cache > > file, as we can just look it up when we want to remove it later on. > > Simplify the structure

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-18 Thread Jani Nikula
On Wed, 19 May 2021, Zhenyu Wang wrote: > Reviewed-by: Zhenyu Wang > > Thanks! Thanks for the review. Please also let Greg know whether he can pick this up via the debugfs tree; I don't care either way. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-18 Thread Zhenyu Wang
On 2021.05.18 18:17:05 +0200, Greg Kroah-Hartman wrote: > There is no need to keep the dentry around for the debugfs kvmgt cache > file, as we can just look it up when we want to remove it later on. > Simplify the structure by removing the dentry and relying on debugfs > to find the dentry to remov

Re: [PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-18 Thread Greg Kroah-Hartman
On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote: > There is no need to keep the dentry around for the debugfs kvmgt cache > file, as we can just look it up when we want to remove it later on. > Simplify the structure by removing the dentry and relying on debugfs > to find the den

[PATCH] drm/i915/gvt: remove local storage of debugfs file

2021-05-18 Thread Greg Kroah-Hartman
There is no need to keep the dentry around for the debugfs kvmgt cache file, as we can just look it up when we want to remove it later on. Simplify the structure by removing the dentry and relying on debugfs to find the dentry to remove when we want to. By doing this change, we remove the last in-