Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Dixit, Ashutosh
On Tue, 28 Mar 2023 02:14:42 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 27/03/2023 18:47, Rodrigo Vivi wrote: > > > > +Daniel > > > > On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: > >> On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: > >>> > >> > >> Hi Rodrigo, > >>

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Dixit, Ashutosh
On Mon, 27 Mar 2023 10:47:25 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, Sorry for the delay, I got pulled away into a couple of other things and could only now get back to this. > > +Daniel > > On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: > > On Sun, 26 Mar 2023 04:52:59 -0700,

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-28 Thread Tvrtko Ursulin
On 27/03/2023 18:47, Rodrigo Vivi wrote: +Daniel On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: Hi Rodrigo, On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote: On Fri, 24 Mar 2023 11:15:02 -0700, Be

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-27 Thread Rodrigo Vivi
+Daniel On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: > On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote: > > > On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > > >

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-27 Thread Dixit, Ashutosh
On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote: > > On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > > > > > > > Hi Vinay, > > > > Thanks for the review. Comments inline below. > > > > > On 3/15

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-27 Thread Dixit, Ashutosh
On Fri, 24 Mar 2023 17:06:33 -0700, Belgaumkar, Vinay wrote: > Hi Vinay, > On 3/24/2023 4:31 PM, Dixit, Ashutosh wrote: > > On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > > Hi Vinay, > > > > Thanks for the review. Comments inline below. > Sorry about asking the same questions all

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-26 Thread Rodrigo Vivi
On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote: > On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > > > > Hi Vinay, > > Thanks for the review. Comments inline below. > > > On 3/15/2023 8:59 PM, Ashutosh Dixit wrote: > > > On dGfx, the PL1 power limit being enabled a

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-24 Thread Belgaumkar, Vinay
On 3/24/2023 4:31 PM, Dixit, Ashutosh wrote: On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: Hi Vinay, Thanks for the review. Comments inline below. Sorry about asking the same questions all over again :) Didn't look at previous versions. On 3/15/2023 8:59 PM, Ashutosh Dixit w

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-24 Thread Dixit, Ashutosh
On Fri, 24 Mar 2023 11:15:02 -0700, Belgaumkar, Vinay wrote: > Hi Vinay, Thanks for the review. Comments inline below. > On 3/15/2023 8:59 PM, Ashutosh Dixit wrote: > > On dGfx, the PL1 power limit being enabled and set to a low value results > > in a low GPU operating freq. It also negates the

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-24 Thread Belgaumkar, Vinay
On 3/15/2023 8:59 PM, Ashutosh Dixit wrote: On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen

[PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-15 Thread Ashutosh Dixit
On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power

Re: [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-11 Thread Dixit, Ashutosh
On Fri, 10 Mar 2023 16:33:58 -0800, Ashutosh Dixit wrote: > > On dGfx, the PL1 power limit being enabled and set to a low value results > in a low GPU operating freq. It also negates the freq raise operation which > is done before GuC firmware load. As a result GuC firmware load can time > out. Suc

[PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-10 Thread Ashutosh Dixit
On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power