Re: [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Dixit, Ashutosh
On Mon, 27 Jun 2022 16:03:46 -0700, Vinay Belgaumkar wrote: > > /* Actual frequency should rise above min */ > - if (max_act_freq == slpc_min_freq) { > + if (max_act_freq <= slpc_min_freq) { > pr_err("Actual freq did not rise above min\n")

[PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also optimize

Re: [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Belgaumkar, Vinay
On 6/24/2022 8:59 PM, Dixit, Ashutosh wrote: On Thu, 23 Jun 2022 16:33:20 -0700, Vinay Belgaumkar wrote: +static int max_granted_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps, u32 *max_act_freq) +{ + struct intel_gt *gt = rps_to_gt(rps); + u32 perf_limit_reasons; +

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Belgaumkar, Vinay
On 6/24/2022 8:59 PM, Dixit, Ashutosh wrote: On Thu, 23 Jun 2022 16:21:46 -0700, Belgaumkar, Vinay wrote: On 6/22/2022 1:32 PM, Dixit, Ashutosh wrote: On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: This test will validate we can achieve actual frequency of RP0. Pcode grants freq

Re: [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-27 Thread Belgaumkar, Vinay
On 6/24/2022 8:59 PM, Dixit, Ashutosh wrote: On Thu, 23 Jun 2022 16:33:20 -0700, Vinay Belgaumkar wrote: +static int max_granted_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps, u32 *max_act_freq) +{ + struct intel_gt *gt = rps_to_gt(rps); + u32 perf_limit_reasons; +

Re: [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-24 Thread Dixit, Ashutosh
On Thu, 23 Jun 2022 16:33:20 -0700, Vinay Belgaumkar wrote: > > +static int max_granted_freq(struct intel_guc_slpc *slpc, struct intel_rps > *rps, u32 *max_act_freq) > +{ > + struct intel_gt *gt = rps_to_gt(rps); > + u32 perf_limit_reasons; > + int err = 0; > > - ig

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-24 Thread Dixit, Ashutosh
On Thu, 23 Jun 2022 16:21:46 -0700, Belgaumkar, Vinay wrote: > On 6/22/2022 1:32 PM, Dixit, Ashutosh wrote: > > On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: > >> This test will validate we can achieve actual frequency of RP0. Pcode > >> grants frequencies based on what GuC is request

[PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-23 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also optimize

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-23 Thread Belgaumkar, Vinay
On 6/22/2022 1:32 PM, Dixit, Ashutosh wrote: On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-22 Thread Dixit, Ashutosh
On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: > > This test will validate we can achieve actual frequency of RP0. Pcode > grants frequencies based on what GuC is requesting. However, thermal > throttling can limit what is being granted. Add a test to request for > max, but don't fail

[PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-10 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also optimize

[PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-10 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also optimize