Re: [PATCH] drm/i915/gt: Avoid duplicating CCS mode workaround

2025-03-25 Thread Andi Shyti
Hi Lucas, > > > > @@ -2897,7 +2897,9 @@ engine_init_workarounds(struct intel_engine_cs > > > > *engine, struct i915_wa_list *wal > > > > */ > > > > if (engine->flags & I915_ENGINE_FIRST_RENDER_COMPUTE) { > > > > general_render_compute_wa_init(engine, wal); > > > >

Re: [PATCH] drm/i915/gt: Avoid duplicating CCS mode workaround

2025-03-25 Thread Lucas De Marchi
On Tue, Mar 25, 2025 at 04:39:57PM +0100, Andi Shyti wrote: Hi Lucas, > > > @@ -2897,7 +2897,9 @@ engine_init_workarounds(struct intel_engine_cs *engine, struct i915_wa_list *wal > > > */ > > > if (engine->flags & I915_ENGINE_FIRST_RENDER_COMPUTE) { > > > gener

Re: [PATCH] drm/i915/gt: Avoid duplicating CCS mode workaround

2025-03-25 Thread Lucas De Marchi
On Tue, Mar 25, 2025 at 03:26:24PM +0100, Andi Shyti wrote: On Tue, Mar 25, 2025 at 01:57:42PM +0100, Chris Wilson wrote: Quoting Andi Shyti (2025-03-25 13:01:37) > When generating workarounds for the CCS engine, specifically for > setting the CCS mode related to compute load balancing, the > fu

Re: [PATCH] drm/i915/gt: Avoid duplicating CCS mode workaround

2025-03-25 Thread Andi Shyti
On Tue, Mar 25, 2025 at 01:57:42PM +0100, Chris Wilson wrote: > Quoting Andi Shyti (2025-03-25 13:01:37) > > When generating workarounds for the CCS engine, specifically for > > setting the CCS mode related to compute load balancing, the > > function 'ccs_engine_wa_mode()' is called twice: once for

Re: [PATCH] drm/i915/gt: Avoid duplicating CCS mode workaround

2025-03-25 Thread Chris Wilson
Quoting Andi Shyti (2025-03-25 13:01:37) > When generating workarounds for the CCS engine, specifically for > setting the CCS mode related to compute load balancing, the > function 'ccs_engine_wa_mode()' is called twice: once for the > render engine and once for the compute engine. > > Add a check

[PATCH] drm/i915/gt: Avoid duplicating CCS mode workaround

2025-03-25 Thread Andi Shyti
When generating workarounds for the CCS engine, specifically for setting the CCS mode related to compute load balancing, the function 'ccs_engine_wa_mode()' is called twice: once for the render engine and once for the compute engine. Add a check to ensure the engine class is compute before applyin