Re: [PATCH] drm/i915/gem: remove unused assignments

2022-06-21 Thread Tvrtko Ursulin
On 21/06/2022 03:26, Katrin Jo wrote: On Mon, Jun 20, 2022 at 6:19 PM Tvrtko Ursulin wrote: On 20/06/2022 11:02, zys.zlj...@gmail.com wrote: From: katrinzhou The variable ret is reassigned and the value EINVAL is never used. Thus, remove the unused assignments. Addresses-Coverity: ("Unu

Re: [PATCH] drm/i915/gem: remove unused assignments

2022-06-21 Thread Katrin Jo
On Mon, Jun 20, 2022 at 6:13 PM Jani Nikula wrote: > > On Mon, 20 Jun 2022, zys.zlj...@gmail.com wrote: > > From: katrinzhou > > > > The variable ret is reassigned and the value EINVAL is never used. > > Thus, remove the unused assignments. > > It's obviously a bug, but it's not obvious just thro

[PATCH] drm/i915/gem: remove unused assignments

2022-06-21 Thread zys . zljxml
From: katrinzhou The variable ret is reassigned and the value EINVAL is never used. Thus, remove the unused assignments. Addresses-Coverity: ("Unused value") Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Signed-off-by: katrinzhou --- drivers/gpu/

Re: [PATCH] drm/i915/gem: remove unused assignments

2022-06-21 Thread Katrin Jo
On Mon, Jun 20, 2022 at 6:19 PM Tvrtko Ursulin wrote: > > > On 20/06/2022 11:02, zys.zlj...@gmail.com wrote: > > From: katrinzhou > > > > The variable ret is reassigned and the value EINVAL is never used. > > Thus, remove the unused assignments. > > > > Addresses-Coverity: ("Unused value") > > Fi

Re: [PATCH] drm/i915/gem: remove unused assignments

2022-06-20 Thread Tvrtko Ursulin
On 20/06/2022 11:02, zys.zlj...@gmail.com wrote: From: katrinzhou The variable ret is reassigned and the value EINVAL is never used. Thus, remove the unused assignments. Addresses-Coverity: ("Unused value") Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameter

Re: [PATCH] drm/i915/gem: remove unused assignments

2022-06-20 Thread Jani Nikula
On Mon, 20 Jun 2022, zys.zlj...@gmail.com wrote: > From: katrinzhou > > The variable ret is reassigned and the value EINVAL is never used. > Thus, remove the unused assignments. It's obviously a bug, but it's not obvious just throwing the code away is the fix. Maybe there's a missing "else" inste