Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-20 Thread Russell King - ARM Linux
Hi Hans, Patch merged, thanks. On Mon, Aug 27, 2018 at 02:28:50PM +0200, Hans Verkuil wrote: > The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to > prevent the CEC framework from retrying the transmit. If the > transmit was successful, then don't set this flag. > > Found by running '

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-14 Thread Daniel Vetter
Hi Russell, On Thu, Sep 13, 2018 at 3:48 PM, Russell King - ARM Linux wrote: > On Thu, Sep 13, 2018 at 03:33:20PM +0200, Hans Verkuil wrote: >> On 09/13/18 15:16, Daniel Vetter wrote: >> > On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: >> >> Hi Hans, >> >> >> >> I'll pi

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Hans Verkuil
On 09/13/18 15:48, Russell King - ARM Linux wrote: > On Thu, Sep 13, 2018 at 03:33:20PM +0200, Hans Verkuil wrote: >> On 09/13/18 15:16, Daniel Vetter wrote: >>> On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: Hi Hans, I'll pick it up in due course. >>>

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Russell King - ARM Linux
On Thu, Sep 13, 2018 at 03:33:20PM +0200, Hans Verkuil wrote: > On 09/13/18 15:16, Daniel Vetter wrote: > > On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: > >> Hi Hans, > >> > >> I'll pick it up in due course. > >> > >> Thanks. > >> > >> On Tue, Sep 11, 2018 at 08:41:59AM

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Daniel Vetter
On Thu, Sep 13, 2018 at 03:33:20PM +0200, Hans Verkuil wrote: > On 09/13/18 15:16, Daniel Vetter wrote: > > On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: > >> Hi Hans, > >> > >> I'll pick it up in due course. > >> > >> Thanks. > >> > >> On Tue, Sep 11, 2018 at 08:41:59AM

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Hans Verkuil
On 09/13/18 15:16, Daniel Vetter wrote: > On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: >> Hi Hans, >> >> I'll pick it up in due course. >> >> Thanks. >> >> On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrote: >>> Russell (or someone else), can you Ack this patc

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Daniel Vetter
On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: > Hi Hans, > > I'll pick it up in due course. > > Thanks. > > On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrote: > > Russell (or someone else), can you Ack this patch? I'd like to get this > > for 4.20. > > > >

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Russell King - ARM Linux
Hi Hans, I'll pick it up in due course. Thanks. On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrote: > Russell (or someone else), can you Ack this patch? I'd like to get this > for 4.20. > > Thanks! > > Hans > > On 08/27/2018 02:28 PM, Hans Verkuil wrote: > > The CEC_TX_STATUS_

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Gustavo Padovan
Hi Hans, Thanks for the patch. On Mon, Aug 27, 2018 at 02:28:50PM +0200, Hans Verkuil wrote: > The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to > prevent the CEC framework from retrying the transmit. If the > transmit was successful, then don't set this flag. > > Found by running '

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-10 Thread Hans Verkuil
Russell (or someone else), can you Ack this patch? I'd like to get this for 4.20. Thanks! Hans On 08/27/2018 02:28 PM, Hans Verkuil wrote: > The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to > prevent the CEC framework from retrying the transmit. If the > transmit was succes

[PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-08-27 Thread Hans Verkuil
The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to prevent the CEC framework from retrying the transmit. If the transmit was successful, then don't set this flag. Found by running 'cec-compliance -A' on a beaglebone box. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/i2c/tda9950.c