Re: [PATCH] drm/hisilicon: Use pcim_enable_device()

2020-12-22 Thread tiantao (H)
在 2020/12/22 16:27, Daniel Vetter 写道: On Tue, Dec 22, 2020 at 1:38 AM tiantao (H) wrote: 在 2020/12/22 6:02, Daniel Vetter 写道: On Mon, Dec 21, 2020 at 08:45:22AM +0800, Tian Tao wrote: Using the managed function simplifies the error handling. After unloading the driver, the PCI device should

Re: [PATCH] drm/hisilicon: Use pcim_enable_device()

2020-12-22 Thread tiantao (H)
在 2020/12/22 6:02, Daniel Vetter 写道: On Mon, Dec 21, 2020 at 08:45:22AM +0800, Tian Tao wrote: Using the managed function simplifies the error handling. After unloading the driver, the PCI device should now get disabled as well. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hi

Re: [PATCH] drm/hisilicon: Use pcim_enable_device()

2020-12-22 Thread Daniel Vetter
On Tue, Dec 22, 2020 at 1:38 AM tiantao (H) wrote: > > > 在 2020/12/22 6:02, Daniel Vetter 写道: > > On Mon, Dec 21, 2020 at 08:45:22AM +0800, Tian Tao wrote: > >> Using the managed function simplifies the error handling. After > >> unloading the driver, the PCI device should now get disabled as > >>

Re: [PATCH] drm/hisilicon: Use pcim_enable_device()

2020-12-21 Thread Daniel Vetter
On Mon, Dec 21, 2020 at 08:45:22AM +0800, Tian Tao wrote: > Using the managed function simplifies the error handling. After > unloading the driver, the PCI device should now get disabled as > well. > > Signed-off-by: Tian Tao > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 ++ >

[PATCH] drm/hisilicon: Use pcim_enable_device()

2020-12-21 Thread Tian Tao
Using the managed function simplifies the error handling. After unloading the driver, the PCI device should now get disabled as well. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/