Re: [PATCH] drm/gma500/oaktrail_lvds: replace continue with break

2021-06-19 Thread Patrik Jakobsson
On Sat, Jun 19, 2021 at 3:40 PM Dan Carpenter wrote: > > On Fri, Jun 18, 2021 at 07:35:24PM +0100, Colin King wrote: > > From: Colin Ian King > > > > Currently a loop scans through the connector list checking > > for connectors that do not match a specific criteria. The > > use of the continue st

Re: [PATCH] drm/gma500/oaktrail_lvds: replace continue with break

2021-06-19 Thread Dan Carpenter
On Fri, Jun 18, 2021 at 07:35:24PM +0100, Colin King wrote: > From: Colin Ian King > > Currently a loop scans through the connector list checking > for connectors that do not match a specific criteria. The > use of the continue statement is a little unintuitive and > can confuse static analysis c

Re: [PATCH] drm/gma500/oaktrail_lvds: replace continue with break

2021-06-18 Thread Patrik Jakobsson
On Fri, Jun 18, 2021 at 8:35 PM Colin King wrote: > > From: Colin Ian King > > Currently a loop scans through the connector list checking > for connectors that do not match a specific criteria. The > use of the continue statement is a little unintuitive and > can confuse static analysis checking.

[PATCH] drm/gma500/oaktrail_lvds: replace continue with break

2021-06-18 Thread Colin King
From: Colin Ian King Currently a loop scans through the connector list checking for connectors that do not match a specific criteria. The use of the continue statement is a little unintuitive and can confuse static analysis checking. Invert the criteria matching logic and use a break to terminat